Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Ensure Gopkg.lock is correct in linting #1687

Merged
merged 2 commits into from
Jul 14, 2018
Merged

Conversation

ValarDragon
Copy link
Contributor

@ValarDragon ValarDragon commented Jul 14, 2018

This adds dep status to the lint process. Also fixes linting errors
that existed earlier. (not sure why they didn't show up on CI)

Closes #1574

  • Updated all relevant documentation (docs/) - n/a
  • Updated all relevant code comments - n.a
  • Wrote tests - n/a
  • Updated CHANGELOG.md - not a user facing change
  • Updated cmd/gaia and examples/ - n/a

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

This adds dep status to the lint process. Also fixes linting errors
that existed earlier. (not sure why they didn't show up on CI)

Closes #1574
@codecov
Copy link

codecov bot commented Jul 14, 2018

Codecov Report

Merging #1687 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1687      +/-   ##
==========================================
- Coverage   62.07%   62.05%   -0.02%     
==========================================
  Files         116      116              
  Lines        6929     6931       +2     
==========================================
  Hits         4301     4301              
- Misses       2385     2387       +2     
  Partials      243      243

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit a2047c5 into master Jul 14, 2018
@cwgoes cwgoes deleted the dev/add_dep_linting branch July 14, 2018 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants