types: Switch table driven test error messages to new format #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make table driven tests in /types follow the format described in #1664
ValarDragon
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1691 +/- ##
==========================================
- Coverage 62.37% 62.05% -0.32%
==========================================
Files 120 116 -4
Lines 7117 6931 -186
==========================================
- Hits 4439 4301 -138
+ Misses 2427 2387 -40
+ Partials 251 243 -8 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1691 +/- ##
==========================================
- Coverage 62.37% 62.05% -0.32%
==========================================
Files 120 116 -4
Lines 7117 6931 -186
==========================================
- Hits 4439 4301 -138
+ Misses 2427 2387 -40
+ Partials 251 243 -8 |
Codecov Report
@@ Coverage Diff @@
## master #1691 +/- ##
==========================================
- Coverage 62.37% 62.05% -0.32%
==========================================
Files 120 116 -4
Lines 7117 6931 -186
==========================================
- Hits 4439 4301 -138
+ Misses 2427 2387 -40
+ Partials 251 243 -8 |
rigelrozanski
approved these changes
Jul 16, 2018
There was a problem hiding this comment.
couple small issues which I just addressed:
- error messages should be lower case/not sentences
erroredit's quite a word :P
error messages are a bit verbose, typically I think it's fine to just have the developer look up where the error is to really understand what's failing, but the use test-case index is great.
Thanks
|
Sounds good to me! I agree, we don't need to always have a message, since you get the line number for whats failing. Should I remove some from here w/ that in mind? |
|
nah, it's fine for now |
ebuchman
added a commit
that referenced
this pull request
Jul 16, 2018
Merge pull request #1691: Table driven test indexes
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make table driven tests in /types follow the format described in #1664
docs/)CHANGELOG.md- not an end user facing changecmd/gaiaandexamples/For Admin Use: