Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: how they're updated #1692

Merged
merged 1 commit into from
Jul 18, 2018
Merged

docs: how they're updated #1692

merged 1 commit into from
Jul 18, 2018

Conversation

zramsay
Copy link
Contributor

@zramsay zramsay commented Jul 16, 2018

same file in Tendermint

  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Updated CHANGELOG.md
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@zramsay zramsay requested a review from jbibla as a code owner July 16, 2018 18:21
@cwgoes cwgoes changed the base branch from master to develop July 16, 2018 19:55
@ebuchman ebuchman merged commit d1a65a1 into develop Jul 18, 2018
@ebuchman ebuchman deleted the zach/docs-explaner branch July 18, 2018 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebuchman ebuchman ebuchman approved these changes

@jbibla jbibla Awaiting requested review from jbibla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zramsay @ebuchman