Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Sims failing and not skipping with empty valset #16947

Merged
merged 1 commit into from
Jul 12, 2023
Merged

fix: Sims failing and not skipping with empty valset #16947

merged 1 commit into from
Jul 12, 2023

Conversation

facundomedica
Copy link
Member

@facundomedica facundomedica commented Jul 12, 2023 •
edited
Loading

Description

Before we were panicking in InitGenesis, so there was a recover in place to intercept up any possible initGenesis returning an empty validator set. Now InitGenesis doesn't panic, so we have to check the error its returning

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@facundomedica facundomedica requested a review from a team as a code owner July 12, 2023 11:08
@github-actions
Copy link
Contributor

@facundomedica your pull request is missing a changelog!

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 12, 2023
julienrbrt
julienrbrt approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@julienrbrt julienrbrt added this pull request to the merge queue Jul 12, 2023
Merged via the queue into main with commit eb0260a Jul 12, 2023
@julienrbrt julienrbrt deleted the facu/fix-sims-initgenesis branch July 12, 2023 12:28
mergify bot pushed a commit that referenced this pull request Jul 12, 2023
@facundomedica @mergify
fix: Sims failing and not skipping with empty valset (#16947)
0814116 
(cherry picked from commit eb0260a)

# Conflicts:
#	simapp/sim_test.go
@mergify mergify bot mentioned this pull request Jul 12, 2023
Merged
julienrbrt added a commit that referenced this pull request Jul 12, 2023
@mergify @facundomedica @julienrbrt
fix: Sims failing and not skipping with empty valset (backport #16947) (
12d9cdc 
#16952)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@facundomedica @julienrbrt