Ready-for-review: Proposal Query filter by status #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b.com/cosmos/cosmos-sdk into sunny/gov_proposalquery_status_filter
sunnya97
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #1697 +/- ##
========================================
Coverage 62.35% 62.35%
========================================
Files 120 120
Lines 7119 7119
========================================
Hits 4439 4439
Misses 2429 2429
Partials 251 251 |
|
Great, let's backport this to gaia-7000 once complete. |
sunnya97
changed the title
Makefile
Outdated
| @@ -119,6 +119,8 @@ test_lint: | |||
| gometalinter.v2 --config=tools/gometalinter.json ./... | |||
| !(gometalinter.v2 --disable-all --enable='errcheck' --vendor ./... | grep -v "client/") | |||
| find . -name '*.go' -type f -not -path "./vendor*" -not -path "*.git*" | xargs gofmt -d -s | |||
| dep status >> /dev/null | |||
There was a problem hiding this comment.
Hmmm, what's this for?
CHANGELOG.md
Outdated
| @@ -32,6 +33,8 @@ BUG FIXES | |||
| * [keys] \#1629 - updating password no longer asks for a new password when the first entered password was incorrect | |||
| * [lcd] importing an account would create a random account | |||
| * [server] 'gaiad init' command family now writes provided name as the moniker in `config.toml` | |||
| * [build] Added Ledger build support via `LEDGER_ENABLED=true|false` | |||
There was a problem hiding this comment.
Do we want this going into master or develop? Not sure if this is supposed to be part of the diff?
There was a problem hiding this comment.
I guess into develop now. I branched this off from master before we switched back to gitflow
types/coin_test.go
Outdated
| @@ -17,9 +17,9 @@ func TestIsPositiveCoin(t *testing.T) { | |||
| {NewCoin("a", -1), false}, | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Same with the CHANGELOG. Not sure if this diff is supposed to be part of this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/)CHANGELOG.mdcmd/gaiaandexamples/For Admin Use: