Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gov): autocli query support #16987

Merged
merged 12 commits into from
Jul 14, 2023
Merged

feat(gov): autocli query support #16987

merged 12 commits into from
Jul 14, 2023

Conversation

julienrbrt
Copy link
Member

Description

ref: #15901

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

julienrbrt
julienrbrt commented Jul 13, 2023
View reviewed changes
x/gov/keeper/grpc_query.go
@@ -179,11 +179,6 @@ func (q queryServer) Params(ctx context.Context, req *v1.QueryParamsRequest) (*v
case v1.ParamTallying:
tallyParams := v1.NewTallyParams(params.Quorum, params.Threshold, params.VetoThreshold)
response.TallyParams = &tallyParams

default:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows to pass no parameters but still return the whole params.

@julienrbrt julienrbrt mentioned this pull request Jul 13, 2023
Closed
17 tasks
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 13, 2023
@julienrbrt julienrbrt marked this pull request as ready for review July 13, 2023 23:17
@julienrbrt julienrbrt requested a review from a team as a code owner July 13, 2023 23:17
tac0turtle
tac0turtle approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one question but otherwise looks good

x/gov/client/cli/query.go
GetCmdQueryVote(ac),
GetCmdQueryVotes(),
GetCmdQueryParams(),
GetCmdQueryParam(),
GetCmdQueryProposer(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reason for this staying?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it queries events and filters (

cosmos-sdk/x/gov/client/utils/query.go

Line 165 in 90b3907

q := fmt.Sprintf("%s.%s='%d'", types.EventTypeSubmitProposal, types.AttributeKeyProposalID, proposalID)
). There is no gRPC endpoint that does that in gov.
In this case, we cannot use AutoCLI. I'll implement #16836, to be able to wire it back in gov.

Copy link
Member Author

@julienrbrt julienrbrt Jul 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that proposers are in the proposals, we could actually introduce a query for it too.

@julienrbrt julienrbrt added this pull request to the merge queue Jul 14, 2023
Merged via the queue into main with commit 8cf483a Jul 14, 2023
@julienrbrt julienrbrt deleted the julien/autocli-gov branch July 14, 2023 09:09
mergify bot pushed a commit that referenced this pull request Jul 14, 2023
@julienrbrt @mergify
feat(gov): autocli query support (#16987)
3c5152c 
(cherry picked from commit 8cf483a)

# Conflicts:
#	x/circuit/go.mod
#	x/circuit/go.sum
#	x/evidence/go.mod
#	x/evidence/go.sum
#	x/gov/client/cli/query.go
@mergify mergify bot mentioned this pull request Jul 14, 2023
Merged
julienrbrt added a commit that referenced this pull request Jul 14, 2023
@mergify @julienrbrt
feat(gov): autocli query support (backport #16987) (#16999)
93a995c 
Co-authored-by: Julien Robert <julien@rbrt.fr>
@Lefey Lefey mentioned this pull request May 11, 2024
Merged
12 tasks
@mergify mergify bot mentioned this pull request May 12, 2024
Merged
12 tasks
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@JeancarloBarrios JeancarloBarrios Awaiting requested review from JeancarloBarrios

@likhita-809 likhita-809 Awaiting requested review from likhita-809

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/circuit C:x/evidence C:x/gov
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienrbrt @tac0turtle