Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text output format of block-results cmd cli #17183

Merged
merged 4 commits into from
Jul 31, 2023

Conversation

zakir-code
Copy link
Contributor

chore: fix misspell

@zakir-code zakir-code requested a review from a team as a code owner July 29, 2023 09:02
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK! Good find on good find @zakir-code 🚀
However, we do not need a changelog, this command has never been released. Can you run make lint-fix as well?

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 29, 2023
@zakir-code
Copy link
Contributor Author

Ok, I was careless, I added the block-results feature to our project very early on, it works really well

@zakir-code
Copy link
Contributor Author

@julienrbrt Excuse me, I still have another question, is the type below deliberately not supporting text type output?

return clientCtx.PrintBytes(json)

err = clientCtx.PrintBytes(json)

@julienrbrt
Copy link
Member

@julienrbrt Excuse me, I still have another question, is the type below deliberately not supporting text type output?

return clientCtx.PrintBytes(json)

err = clientCtx.PrintBytes(json)

Yes, these are expected (signing or decoding makes sense to output only json)

@zakir-code
Copy link
Contributor Author

@julienrbrt Excuse me, I still have another question, is the type below deliberately not supporting text type output?

return clientCtx.PrintBytes(json)

err = clientCtx.PrintBytes(json)

Yes, these are expected (signing or decoding makes sense to output only json)

I think it is possible to set the --output flag to be hidden, like this

flags.AddTxFlagsToCmd(cmd)
_ = cmd.Flags().MarkHidden(flags.FlagOutput)

@julienrbrt
Copy link
Member

I think it is possible to set the --output flag to be hidden, like this

flags.AddTxFlagsToCmd(cmd)
_ = cmd.Flags().MarkHidden(flags.FlagOutput)

Good one, feel free to add that here 👍🏾

@julienrbrt julienrbrt added this pull request to the merge queue Jul 31, 2023
Merged via the queue into cosmos:main with commit f47749b Jul 31, 2023
mergify bot pushed a commit that referenced this pull request Jul 31, 2023
Co-authored-by: Julien Robert <julien@rbrt.fr>
(cherry picked from commit f47749b)
julienrbrt pushed a commit that referenced this pull request Jul 31, 2023
…17219)

Co-authored-by: zakir <80246097+zakir-code@users.noreply.github.com>
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants