Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): Add debuging dependencies directly into the dockerfile #17228

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

Anmol1696
Copy link
Contributor

@Anmol1696 Anmol1696 commented Jul 31, 2023

Description

Some minimal dependencies are always used with docker containers, specially for debugging. Here we add curl make bash jq sed dependencies directly into the docker-image

Docker image size goes from 92.1MB to 99.7MB (for arm images)

Additionally it will also alow out of the box docker images being used with upcoming PR: #17077


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@Anmol1696 Anmol1696 requested a review from a team as a code owner July 31, 2023 16:29
@Anmol1696 Anmol1696 changed the title feat(docker): Add debuging dependencies directly into the simapp dockerfile feat(docker): Add debuging dependencies directly into the dockerfile Jul 31, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julienrbrt julienrbrt added backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Jul 31, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Jul 31, 2023
Merged via the queue into cosmos:main with commit 095a641 Jul 31, 2023
mergify bot pushed a commit that referenced this pull request Jul 31, 2023
mergify bot pushed a commit that referenced this pull request Jul 31, 2023
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release Type: Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants