Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/stake: Fix inflation calculation period check #1738

Merged
merged 2 commits into from
Jul 18, 2018
Merged

x/stake: Fix inflation calculation period check #1738

merged 2 commits into from
Jul 18, 2018

Conversation

hendrikhofstadt
Copy link
Contributor

@hendrikhofstadt hendrikhofstadt commented Jul 18, 2018 •
edited by rigelrozanski
Loading

Closes #1736

There was a logical flaw causing inflation calculation to be performed on every block causing a massive performance overhead and slowing sync down over time.

This breaks current testnets because it causes the current state to be invalid.

  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Updated CHANGELOG.md
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@hendrikhofstadt hendrikhofstadt changed the title Closes #1736 : Fix inflation calculation period check x/stake: Fix inflation calculation period check Jul 18, 2018
@codecov
Copy link

codecov bot commented Jul 18, 2018 •
edited
Loading

Codecov Report

Merging #1738 into develop will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           develop    #1738   +/-   ##
========================================
  Coverage    62.35%   62.35%           
========================================
  Files          120      120           
  Lines         7119     7119           
========================================
  Hits          4439     4439           
  Misses        2429     2429           
  Partials       251      251

@hendrikhofstadt hendrikhofstadt mentioned this pull request Jul 18, 2018
Closed
4 tasks
@ValarDragon ValarDragon added ready-for-review T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). labels Jul 18, 2018
@ValarDragon
Copy link
Contributor

LGTM! Great catch.

rigelrozanski
rigelrozanski approved these changes Jul 18, 2018
View reviewed changes
Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rigelrozanski rigelrozanski merged commit a8b6a10 into cosmos:develop Jul 18, 2018
wukongcheng added a commit to wukongcheng/cosmos-sdk that referenced this pull request Aug 13, 2018
@wukongcheng
fix bug (cosmos#1738)
1fa0223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigelrozanski rigelrozanski rigelrozanski approved these changes

@cwgoes cwgoes Awaiting requested review from cwgoes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hendrikhofstadt @ValarDragon @rigelrozanski