R4R: remove rationals in endblock

[rigelrozanski]

After thinking about it a bit more, I think the rational calculation actually makes a bunch of sense, we were just using outrageous precision, I drastically reduced the precision to acceptable amount as well as added rounding in all the appropriate places to improve performance.

Additionally, there was an unnecessary store read and write in the end-blocker which was isolated to it's required location.

closes #1743

• Updated all relevant documentation (docs/)
• Updated all relevant code comments
• Wrote tests
• Updated CHANGELOG.md
• Updated cmd/gaia and examples/

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #1751 into develop will decrease coverage by <.01%.
The diff coverage is 77.77%.

@@             Coverage Diff             @@
##           develop    #1751      +/-   ##
===========================================
- Coverage    63.46%   63.46%   -0.01%     
===========================================
  Files          117      117              
  Lines         6922     6927       +5     
===========================================
+ Hits          4393     4396       +3     
- Misses        2274     2276       +2     
  Partials       255      255

[ValarDragon]

Could this be easily adapted to just a benchmark of the inflation calculation? I think thats valuable, regardless of whether or not we're doing rational math.

[rigelrozanski]

removed couldn't get the benchmarking to work as expected - should add benchmarks in a separate PR

[rigelrozanski]

But yeah I mean the inflation calculation is within here, we could benchmark both, but honestly think it's probably enough to benchmark processing provisions because it's so tightly coupled with the inflation calculation (and is the higher level calculation)

[ValarDragon]

Sounds good! Thanks for looking into it!

[ValarDragon]

Not super related, but we should benchmark if the order of quotient and multiplication affects performance. Such testing could be done in the rational package.

[cwgoes]

utACK

If there are any edge cases (particular choices of inflation parameters) where this rounding leads to substantial divergence from the "pure" model, would be nice to document.