Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(baseapp): use no-op logger #17528

Merged
merged 1 commit into from
Aug 24, 2023
Merged

test(baseapp): use no-op logger #17528

merged 1 commit into from
Aug 24, 2023

Conversation

julienrbrt
Copy link
Member

Description

Sometimes tests are failing in CI because the test logger does not work properly.
This updates it to always use a no-op logger within the baseapp tests.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Aug 24, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner August 24, 2023 18:55
@tac0turtle tac0turtle added this pull request to the merge queue Aug 24, 2023
Merged via the queue into main with commit bb106cb Aug 24, 2023
48 of 50 checks passed
@tac0turtle tac0turtle deleted the julien/tests-baseapp branch August 24, 2023 23:17
mergify bot pushed a commit that referenced this pull request Aug 24, 2023
tac0turtle pushed a commit that referenced this pull request Aug 25, 2023
Co-authored-by: Julien Robert <julien@rbrt.fr>
julienrbrt added a commit that referenced this pull request Aug 25, 2023
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants