Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve DeductFeeDecorator godoc #17559

Merged
merged 2 commits into from
Aug 28, 2023
Merged

docs: improve DeductFeeDecorator godoc #17559

merged 2 commits into from
Aug 28, 2023

Conversation

rootulp
Copy link
Contributor

@rootulp rootulp commented Aug 28, 2023

Closes #17553

@rootulp rootulp requested a review from a team as a code owner August 28, 2023 13:43
tac0turtle
tac0turtle approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

atheeshp
atheeshp approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@atheeshp atheeshp added this pull request to the merge queue Aug 28, 2023
Merged via the queue into cosmos:main with commit acc8c4c Aug 28, 2023
44 of 45 checks passed
@julienrbrt
Copy link
Member

@Mergifyio backport release/v0.50.x

@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2023 •
edited
Loading

backport release/v0.50.x

✅ Backports have been created

@julienrbrt
Copy link
Member

@Mergifyio backport release/v0.47.x

@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2023 •
edited
Loading

backport release/v0.47.x

✅ Backports have been created

This was referenced Aug 31, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request Aug 31, 2023
@rootulp @mergify
docs: improve DeductFeeDecorator godoc (#17559)
ebcceb9 
Co-authored-by: Marko <marko@baricevic.me>
(cherry picked from commit acc8c4c)
mergify bot pushed a commit that referenced this pull request Aug 31, 2023
@rootulp @mergify
docs: improve DeductFeeDecorator godoc (#17559)
df517bf 
Co-authored-by: Marko <marko@baricevic.me>
(cherry picked from commit acc8c4c)
julienrbrt pushed a commit that referenced this pull request Aug 31, 2023
@mergify @rootulp
docs: improve DeductFeeDecorator godoc (backport #17559) (#17589)
b2627e9 
Co-authored-by: Rootul P <rootulp@gmail.com>
julienrbrt pushed a commit that referenced this pull request Aug 31, 2023
@mergify @rootulp
docs: improve DeductFeeDecorator godoc (backport #17559) (#17590)
273bb7d 
Co-authored-by: Rootul P <rootulp@gmail.com>
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atheeshp atheeshp atheeshp approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@samricotta samricotta Awaiting requested review from samricotta

Assignees

@tac0turtle tac0turtle

@samricotta samricotta

@atheeshp atheeshp

Labels
C:x/auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeductFeeDecorator appears incorrect
5 participants
@rootulp @julienrbrt @tac0turtle @atheeshp @samricotta