Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(x/genutil): Allow creation of AppGenesis without a file lookup #17571

Merged
merged 5 commits into from
Aug 29, 2023
Merged

feat(x/genutil): Allow creation of AppGenesis without a file lookup #17571

merged 5 commits into from
Aug 29, 2023

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Aug 29, 2023 •
edited
Loading

Description

Closes: #17570

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:x/genutil genutil module issues label Aug 29, 2023
@chatton chatton changed the title feature: Allow creation of AppGenesis without a file lookup feat: Allow creation of AppGenesis without a file lookup Aug 29, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 29, 2023
View reviewed changes
x/genutil/types/genesis.go Fixed Show fixed Hide fixed
@chatton chatton marked this pull request as ready for review August 29, 2023 12:43
@chatton chatton requested a review from a team as a code owner August 29, 2023 12:43
julienrbrt
julienrbrt reviewed Aug 29, 2023
View reviewed changes
x/genutil/types/genesis.go Outdated

genesisFile, err := AppGenesisFromReader(bufio.NewReader(file))
if err != nil {
return nil, err
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we wrap the error to still include the file name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@julienrbrt julienrbrt changed the title feat: Allow creation of AppGenesis without a file lookup feat(x/genutil): Allow creation of AppGenesis without a file lookup Aug 29, 2023
tac0turtle
tac0turtle approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@tac0turtle tac0turtle added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Aug 29, 2023
julienrbrt
julienrbrt approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

x/genutil/types/genesis.go Outdated Show resolved Hide resolved
@chatton @julienrbrt
Update x/genutil/types/genesis.go
e1489d1 
Co-authored-by: Julien Robert <julien@rbrt.fr>
@julienrbrt julienrbrt added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit 0a253f3 Aug 29, 2023
48 checks passed
@julienrbrt julienrbrt deleted the issue#17570-allow-creation-of-app-genesis branch August 29, 2023 14:44
mergify bot pushed a commit that referenced this pull request Aug 29, 2023
@chatton @mergify
feat(x/genutil): Allow creation of AppGenesis without a file lookup (#…
3a65347 
…17571)

Co-authored-by: Julien Robert <julien@rbrt.fr>
(cherry picked from commit 0a253f3)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Aug 29, 2023
Merged
julienrbrt pushed a commit that referenced this pull request Aug 29, 2023
@mergify @chatton @tac0turtle
feat(x/genutil): Allow creation of AppGenesis without a file lookup (…
6e68abc 
…backport #17571) (#17573)

Co-authored-by: Cian Hatton <cianhatton@gmail.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
@chatton chatton mentioned this pull request Sep 4, 2023
Merged
9 tasks
@colin-axner colin-axner mentioned this pull request Sep 4, 2023
Closed
3 tasks
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@samricotta samricotta Awaiting requested review from samricotta

Assignees

@tac0turtle tac0turtle

@julienrbrt julienrbrt

Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/genutil genutil module issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Allow creation of AppGenesis without a file lookup
3 participants
@chatton @tac0turtle @julienrbrt