Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add genesis changes in upgrading.md #17596

Merged
merged 1 commit into from
Aug 31, 2023
Merged

docs: add genesis changes in upgrading.md #17596

merged 1 commit into from
Aug 31, 2023

Conversation

julienrbrt
Copy link
Member

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Aug 31, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner August 31, 2023 11:18
@github-actions github-actions bot added the C:x/genutil genutil module issues label Aug 31, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Aug 31, 2023
Merged via the queue into main with commit 0868daa Aug 31, 2023
43 checks passed
@julienrbrt julienrbrt deleted the julien/genesis-docs branch August 31, 2023 13:42
mergify bot pushed a commit that referenced this pull request Aug 31, 2023
@julienrbrt @mergify
docs: add genesis changes in upgrading.md (#17596)
535e219 
(cherry picked from commit 0868daa)

# Conflicts:
#	UPGRADING.md
@mergify mergify bot mentioned this pull request Aug 31, 2023
Merged
julienrbrt added a commit that referenced this pull request Aug 31, 2023
@mergify @julienrbrt
docs: add genesis changes in upgrading.md (backport #17596) (#17598)
0996c19 
Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facundomedica facundomedica facundomedica approved these changes

@testinginprod testinginprod Awaiting requested review from testinginprod

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/genutil genutil module issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienrbrt @facundomedica