-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove duplicated app.Close call #17619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, notes for other reviewers:
Lines 598 to 603 in 9766142
cleanupFn = func() { | |
traceCleanupFn() | |
if localErr := app.Close(); localErr != nil { | |
svrCtx.Logger.Error(localErr.Error()) | |
} | |
} |
The function startApp
returns the appCleanupFn
that contains the call to the stop method and the app
that gets passed into startInProcess
.
@Mergifyio backport release/v0.50.x |
✅ Backports have been created
|
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> (cherry picked from commit 202c291)
Let's (reviewers) watch out to prefix properly the PR. |
Description
the
app.Close
is called in theappCleanupFunc
, so no need to call in other places.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change