Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicated app.Close call #17619

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Sep 5, 2023

Description

the app.Close is called in the appCleanupFunc, so no need to call in other places.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@yihuang yihuang requested a review from a team as a code owner September 5, 2023 03:08
Copy link
Member

@facundomedica facundomedica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, notes for other reviewers:

cosmos-sdk/server/start.go

Lines 598 to 603 in 9766142

cleanupFn = func() {
traceCleanupFn()
if localErr := app.Close(); localErr != nil {
svrCtx.Logger.Error(localErr.Error())
}
}

The function startApp returns the appCleanupFn that contains the call to the stop method and the app that gets passed into startInProcess.

@tac0turtle tac0turtle added this pull request to the merge queue Sep 5, 2023
Merged via the queue into cosmos:main with commit 202c291 Sep 5, 2023
43 of 46 checks passed
@yihuang yihuang deleted the app-close branch September 5, 2023 07:30
@julienrbrt julienrbrt changed the title remove duplicated app.Close call fix: remove duplicated app.Close call Sep 6, 2023
@julienrbrt
Copy link
Member

@Mergifyio backport release/v0.50.x

@mergify
Copy link
Contributor

mergify bot commented Sep 6, 2023

backport release/v0.50.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 6, 2023
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
(cherry picked from commit 202c291)
@julienrbrt
Copy link
Member

Let's (reviewers) watch out to prefix properly the PR.
The end goal is to generate the changelog, but we couldn't do it last time because our commit history was usually bad prefixed.

tac0turtle pushed a commit that referenced this pull request Sep 6, 2023
Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants