Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
buf includes well known types (e.g.
google/protobuf/any
,google/protobuf/descriptor
etc.) implicitly. Hencebuf generate
does not need references to them.However,
buf export
which is supposed to export all protos AND their dependencies to a specified folder (useful if you want to run some other proto tool on the SDK protos for whatever reason) assumes the same and does NOT export such well known types.By explicitly including the
protocolbuffers/wellknowntypes
dep (https://buf.build/protocolbuffers/wellknowntypes) in buf.yaml,buf export
will actually export the protos for those well known types as well.This may be an edge-case scenario but seems useful (and was to me) so I thought a PR wouldn't hurt. Up to the maintaining team to decide if worth merging
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change