Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unneeded code #17741

Merged
merged 5 commits into from
Sep 14, 2023
Merged

chore: remove unneeded code #17741

merged 5 commits into from
Sep 14, 2023

Conversation

tac0turtle
Copy link
Member

Description

this pr removes some unneeded code from circuit and runtime

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle marked this pull request as ready for review September 14, 2023 13:11
@tac0turtle tac0turtle requested a review from a team as a code owner September 14, 2023 13:11
julienrbrt
julienrbrt approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! backport?

@tac0turtle
Copy link
Member Author

lgtm! backport?

dont think there is a need

julienrbrt
julienrbrt reviewed Sep 14, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@julienrbrt
Copy link
Member

lgtm! backport?

dont think there is a need

For circuit that avoids introducing and then remove APIs, as circuit never been released.

@tac0turtle tac0turtle added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Sep 14, 2023
@julienrbrt
Copy link
Member

If we backport circuit changes only, we do not need a changelog in it either :)

@tac0turtle tac0turtle added this pull request to the merge queue Sep 14, 2023
Merged via the queue into main with commit 98895f4 Sep 14, 2023
50 checks passed
@tac0turtle tac0turtle deleted the marko/circuit_cleanup branch September 14, 2023 15:45
mergify bot pushed a commit that referenced this pull request Sep 14, 2023
@tac0turtle @mergify
chore: remove unneeded code (#17741)
da1d8cb 
(cherry picked from commit 98895f4)

# Conflicts:
#	runtime/module.go
#	runtime/services.go
@mergify mergify bot mentioned this pull request Sep 14, 2023
Merged
tac0turtle added a commit that referenced this pull request Sep 14, 2023
@mergify @tac0turtle
chore: remove unneeded code (backport #17741) (#17744)
b1dd67a 
Co-authored-by: Marko <marbar3778@yahoo.com>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski kocubinski is a code owner

@likhita-809 likhita-809 Awaiting requested review from likhita-809

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/circuit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tac0turtle @julienrbrt