Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Update PULL_REQUEST_TEMPLATE.md #1778

Merged
merged 1 commit into from
Jul 20, 2018
Merged

R4R: Update PULL_REQUEST_TEMPLATE.md #1778

merged 1 commit into from
Jul 20, 2018

Conversation

rigelrozanski
Copy link
Contributor

minor

  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Updated CHANGELOG.md
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

ValarDragon
ValarDragon approved these changes Jul 20, 2018
View reviewed changes
Copy link
Contributor

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 20, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@f3a1290). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #1778   +/-   ##
==========================================
  Coverage           ?   62.77%           
==========================================
  Files              ?      122           
  Lines              ?     7125           
  Branches           ?        0           
==========================================
  Hits               ?     4473           
  Misses             ?     2390           
  Partials           ?      262

cwgoes
cwgoes approved these changes Jul 20, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit bf3bd57 into develop Jul 20, 2018
@cwgoes cwgoes deleted the rigel/PR-template-update branch July 20, 2018 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@ValarDragon ValarDragon ValarDragon approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rigelrozanski @ValarDragon @cwgoes