Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(client/keys): Test_runImportCmd unique dir per test #17863

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

JulianToledano
Copy link
Contributor

Description

Closes:
#17854


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@JulianToledano JulianToledano requested a review from a team as a code owner September 25, 2023 09:17
@JulianToledano JulianToledano changed the title fix: client/keys Test_runImportCmd unique dir [audit] client/keys: Test_runImportCmd unique dir per test Sep 25, 2023
@github-actions github-actions bot added C:CLI C:Keys Keybase, KMS and HSMs labels Sep 25, 2023
@JulianToledano JulianToledano changed the title [audit] client/keys: Test_runImportCmd unique dir per test test (client/keys): Test_runImportCmd unique dir per test Sep 25, 2023
@julienrbrt julienrbrt changed the title test (client/keys): Test_runImportCmd unique dir per test test(client/keys): Test_runImportCmd unique dir per test Sep 25, 2023
@tac0turtle tac0turtle self-assigned this Sep 25, 2023
@tac0turtle tac0turtle added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Sep 25, 2023
@tac0turtle tac0turtle added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit 2b22254 Sep 25, 2023
53 of 56 checks passed
@tac0turtle tac0turtle deleted the julian/fix-keys-test-tempdir branch September 25, 2023 10:51
mergify bot pushed a commit that referenced this pull request Sep 25, 2023
tac0turtle pushed a commit that referenced this pull request Sep 25, 2023
…7863) (#17865)

Co-authored-by: Julián Toledano <JulianToledano@users.noreply.github.com>
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:Keys Keybase, KMS and HSMs
Projects
None yet
2 participants