Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(confix): add view command #17904

Merged
merged 6 commits into from
Sep 28, 2023
Merged

feat(confix): add view command #17904

merged 6 commits into from
Sep 28, 2023

Conversation

julienrbrt
Copy link
Member

Description

Add view command.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner September 27, 2023 12:47
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Sep 27, 2023
@julienrbrt julienrbrt changed the title feat(config): add view command feat(confix): add view command Sep 27, 2023
@github-actions github-actions bot added the C:Confix Issues and PR related to Confix label Sep 27, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 27, 2023
View reviewed changes
tools/confix/cmd/view.go Dismissed Show dismissed Hide dismissed
likhita-809
likhita-809 reviewed Sep 28, 2023
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to view any given toml files existing in config ?
Can you add tests to this ?

@julienrbrt
Copy link
Member Author

Is this supposed to view any given toml files existing in config ?

Can you add tests to this ?

Yes, exactly.

Will do 👍

facundomedica
facundomedica approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@facundomedica facundomedica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, +1 to add a small test if possible

@julienrbrt julienrbrt added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit f2d5aeb Sep 28, 2023
49 of 50 checks passed
@julienrbrt julienrbrt deleted the julien/confix branch September 28, 2023 09:27
mergify bot pushed a commit that referenced this pull request Sep 28, 2023
@julienrbrt @mergify
feat(confix): add view command (#17904)
dd8364c 
(cherry picked from commit f2d5aeb)

# Conflicts:
#	tools/confix/go.mod
@mergify mergify bot mentioned this pull request Sep 28, 2023
Merged
julienrbrt added a commit that referenced this pull request Sep 28, 2023
@mergify @julienrbrt
feat(confix): add view command (backport #17904) (#17918)
74e8995 
Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likhita-809 likhita-809 likhita-809 left review comments

@facundomedica facundomedica facundomedica approved these changes

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:Confix Issues and PR related to Confix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julienrbrt @facundomedica @likhita-809