Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(x/gov): remove gov vote and proposal based telemetry #17910

Merged
merged 2 commits into from
Sep 27, 2023
Merged

refactor(x/gov): remove gov vote and proposal based telemetry #17910

merged 2 commits into from
Sep 27, 2023

Conversation

tac0turtle
Copy link
Member

Description

removes telemetry for votes and proposals as the data will be incorrect

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle added backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Sep 27, 2023
@tac0turtle tac0turtle requested a review from a team as a code owner September 27, 2023 16:25
alexanderbez
alexanderbez approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

julienrbrt
julienrbrt approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a Client Breaking Changelog?

@julienrbrt julienrbrt changed the title chore: remove gov vote and proposal based telemetry refactor(gov): remove gov vote and proposal based telemetry Sep 27, 2023
@julienrbrt julienrbrt changed the title refactor(gov): remove gov vote and proposal based telemetry refactor(x/gov): remove gov vote and proposal based telemetry Sep 27, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Sep 27, 2023
Merged via the queue into main with commit 5e53fb2 Sep 27, 2023
49 checks passed
@julienrbrt julienrbrt deleted the marko/audit_5 branch September 27, 2023 18:56
mergify bot pushed a commit that referenced this pull request Sep 27, 2023
@tac0turtle @mergify
refactor(x/gov): remove gov vote and proposal based telemetry (#17910)
8f2de65 
(cherry picked from commit 5e53fb2)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Sep 27, 2023
Merged
mergify bot pushed a commit that referenced this pull request Sep 27, 2023
@tac0turtle @mergify
refactor(x/gov): remove gov vote and proposal based telemetry (#17910)
1846f2e 
(cherry picked from commit 5e53fb2)

# Conflicts:
#	CHANGELOG.md
#	x/gov/keeper/msg_server.go
@mergify mergify bot mentioned this pull request Sep 27, 2023
Merged
julienrbrt added a commit that referenced this pull request Sep 27, 2023
@mergify @tac0turtle @julienrbrt
refactor(x/gov): remove gov vote and proposal based telemetry (backport
71c9b76 
#17910) (#17915)

Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
julienrbrt added a commit that referenced this pull request Sep 27, 2023
@mergify @tac0turtle @julienrbrt
refactor(x/gov): remove gov vote and proposal based telemetry (backport
afd4d9d 
#17910) (#17916)

Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
mmsqe pushed a commit to mmsqe/cosmos-sdk that referenced this pull request Oct 9, 2023
@mergify @tac0turtle
@julienrbrt @mmsqe
refactor(x/gov): remove gov vote and proposal based telemetry (backport
60909f3 
cosmos#17910) (cosmos#17916)

Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@JimLarson JimLarson mentioned this pull request Mar 1, 2024
Open
@faddat faddat mentioned this pull request Mar 20, 2024
Open
12 tasks
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski

@samricotta samricotta Awaiting requested review from samricotta

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/gov
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tac0turtle @alexanderbez @julienrbrt