Fix gaiad export #1800
Merged
Fix gaiad export #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnitylChaos
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #1800 +/- ##
===========================================
+ Coverage 63.44% 63.44% +<.01%
===========================================
Files 117 117
Lines 6937 6938 +1
===========================================
+ Hits 4401 4402 +1
Misses 2281 2281
Partials 255 255 |
|
Should add a new test which demonstrated the old failing behaviour. Also should add to the |
baseapp/baseapp.go
Outdated
| @@ -190,7 +190,7 @@ func (app *BaseApp) initFromStore(mainKey sdk.StoreKey) error { | |||
| if main == nil { | |||
| return errors.New("baseapp expects MultiStore with 'main' KVStore") | |||
| } | |||
|
|
|||
| app.setCheckState(abci.Header{}) | |||
There was a problem hiding this comment.
I'd add a comment here explaining why this line is necessary.
UnitylChaos
force-pushed
the
jlandrews/gaiad-export
branch
from
f973729 to
5ab27f7
Compare
rigelrozanski
approved these changes
Jul 26, 2018
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1799
docs/)PENDING.mdcmd/gaiaandexamples/For Admin Use: