Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed governance bug with iterate delegations #1801

Merged
merged 3 commits into from
Jul 24, 2018
Merged

Fixed governance bug with iterate delegations #1801

merged 3 commits into from
Jul 24, 2018

Conversation

sunnya97
Copy link
Member

@sunnya97 sunnya97 commented Jul 24, 2018 •
edited by cwgoes
Loading

Closes #1787

  • Linked to github-issue with discussion and accepted design
  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Added entries in PENDING.md
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 24, 2018 •
edited
Loading

Codecov Report

Merging #1801 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1801      +/-   ##
===========================================
- Coverage    63.46%   63.45%   -0.01%     
===========================================
  Files          117      117              
  Lines         6927     6921       -6     
===========================================
- Hits          4396     4392       -4     
+ Misses        2276     2274       -2     
  Partials       255      255

@cwgoes cwgoes mentioned this pull request Jul 24, 2018
Merged
8 tasks
cwgoes
cwgoes suggested changes Jul 24, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changelog update, otherwise LGTM.

cwgoes
cwgoes approved these changes Jul 24, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

@cwgoes cwgoes merged commit 89eba49 into develop Jul 24, 2018
@cwgoes cwgoes deleted the sunny/gov_bug_fix branch July 24, 2018 19:01
@sunnya97
Copy link
Member Author

@cwgoes Do we have to cherry pick this somewhere for the release?

@cwgoes
Copy link
Contributor

cwgoes commented Jul 24, 2018

#1769

jaekwon pushed a commit that referenced this pull request Jul 25, 2018
@sunnya97 @jaekwon
Merge PR #1801: Fixed governance bug with iterate delegations
8538a7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunnya97 @cwgoes