Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(x/gov): refactor q gov proposer #18025

Merged
merged 2 commits into from
Oct 18, 2023
Merged

refactor(x/gov): refactor q gov proposer #18025

merged 2 commits into from
Oct 18, 2023

Conversation

julienrbrt
Copy link
Member

Description

Closes: #18024

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt marked this pull request as ready for review October 9, 2023 20:29
@julienrbrt julienrbrt requested a review from a team as a code owner October 9, 2023 20:29
@github-prbot github-prbot requested review from a team, facundomedica and tac0turtle and removed request for a team October 9, 2023 20:29
@github-actions

This comment has been minimized.

Sign in to view
tac0turtle
tac0turtle reviewed Oct 10, 2023
View reviewed changes
x/gov/keeper/grpc_query.go Outdated
@@ -275,6 +275,19 @@ func (q queryServer) TallyResult(ctx context.Context, req *v1.QueryTallyResultRe
return &v1.QueryTallyResultResponse{Tally: &tallyResult}, nil
}

// ProposerOfProposal returns the proposer of a governance proposal
func (q queryServer) ProposerOfProposal(ctx context.Context, req *v1.QueryProposerOfProposalRequest) (*v1.QueryProposerOfProposalResponse, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we have a proposal query why do we need a proposer query?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that we are not breaking and improve this command: https://github.com/cosmos/cosmos-sdk/blob/v0.50.0-rc.1/x/gov/client/cli/query.go#L38-L74

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it not be easier to direct people to the proposal command? the other command probably never worked properly as well

Copy link
Member Author

@julienrbrt julienrbrt Oct 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on what we prefer, costs nothing to add, but we could delete it as well and alias proposer to proposal.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can merge, mainly thinking how to avoid more code to maintain in the long run.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I understand. However that is very little code. All that generated code makes it look like it is much.
🤷‍♂️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its more to maintain into the future if we try to rewrite things is my main gripe. Less features = less code = less to maintain. Some features are needed, but worried what could lead from this, making query requests for single values is overkill. Thats my take but wont block the merge

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sorta agree, however I really want to delete the crappy current proposer command.
I will add an alias to proposal as proposer as suggested as you can still get the value that way.

@julienrbrt julienrbrt mentioned this pull request Oct 10, 2023
Merged
20 tasks
@julienrbrt julienrbrt changed the title feat(x/gov): add proposer of proposal query refactor(x/gov): refactor q gov proposer Oct 17, 2023
@julienrbrt julienrbrt changed the title refactor(x/gov): refactor q gov proposer refactor(x/gov): refactor q gov proposer Oct 17, 2023
@julienrbrt julienrbrt requested a review from tac0turtle October 17, 2023 09:46
testinginprod
testinginprod approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@testinginprod testinginprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tac0turtle tac0turtle added this pull request to the merge queue Oct 18, 2023
Merged via the queue into main with commit 033b840 Oct 18, 2023
51 checks passed
@tac0turtle tac0turtle deleted the julien/proposer branch October 18, 2023 11:57
@julienrbrt
Copy link
Member Author

@Mergifyio backport release/v0.50.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 10, 2023 •
edited
Loading

backport release/v0.50.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 10, 2023
@julienrbrt @mergify
refactor(x/gov): refactor q gov proposer (#18025)
6e6bd4a 
(cherry picked from commit 033b840)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Nov 10, 2023
Merged
julienrbrt added a commit that referenced this pull request Nov 10, 2023
@mergify @julienrbrt
refactor(x/gov): refactor q gov proposer (backport #18025) (#18432)
2b42efc 
Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testinginprod testinginprod testinginprod approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@facundomedica facundomedica Awaiting requested review from facundomedica

Assignees

@likhita-809 likhita-809

@testinginprod testinginprod

Labels
C:CLI C:x/gov
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor appd q gov proposer
4 participants
@julienrbrt @tac0turtle @testinginprod @likhita-809