Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(x/authz): extend validate genesis #18042

Merged
merged 4 commits into from
Oct 11, 2023
Merged

refactor(x/authz): extend validate genesis #18042

merged 4 commits into from
Oct 11, 2023

Conversation

tac0turtle
Copy link
Member

Description

A20

this pr proposes removing validate genesis as it was not doing anything before, its unclear if its needed?

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle requested a review from a team as a code owner October 10, 2023 13:09
julienrbrt
julienrbrt previously approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport labels?

x/authz/module/module.go Outdated Show resolved Hide resolved
@julienrbrt julienrbrt dismissed their stale review October 10, 2023 16:31

discussing on slack

@julienrbrt julienrbrt changed the title chore: remove validate genesis from authz refactor(x/authz): extend validate genesis Oct 11, 2023
julienrbrt
julienrbrt approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

x/authz/genesis.go Outdated Show resolved Hide resolved
@tac0turtle tac0turtle added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit 26277eb Oct 11, 2023
48 of 49 checks passed
@tac0turtle tac0turtle deleted the marko/22 branch October 11, 2023 14:03
@tac0turtle
Copy link
Member Author

@Mergifyio backport release/v0.50x

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2023

backport release/v0.50x

❌ No backport have been created

  • Backport to branch release/v0.50x failed

GitHub error: Branch not found

@tac0turtle
Copy link
Member Author

@Mergifyio backport release/v0.50.x

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2023 •
edited
Loading

backport release/v0.50.x

✅ Backports have been created

@tac0turtle
Copy link
Member Author

@Mergifyio backport release/v0.47.x

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2023 •
edited
Loading

backport release/v0.47.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 23, 2023
@tac0turtle @mergify
refactor(x/authz): extend validate genesis (#18042)
35542fc 
(cherry picked from commit 26277eb)
@mergify mergify bot mentioned this pull request Oct 23, 2023
Merged
mergify bot pushed a commit that referenced this pull request Oct 23, 2023
@tac0turtle @mergify
refactor(x/authz): extend validate genesis (#18042)
ed7870b 
(cherry picked from commit 26277eb)
@mergify mergify bot mentioned this pull request Oct 23, 2023
Merged
julienrbrt pushed a commit that referenced this pull request Oct 23, 2023
@mergify @tac0turtle
refactor(x/authz): extend validate genesis (backport #18042) (#18208)
362f234 
Co-authored-by: Marko <marbar3778@yahoo.com>
julienrbrt pushed a commit that referenced this pull request Oct 23, 2023
@mergify @tac0turtle
refactor(x/authz): extend validate genesis (backport #18042) (#18207)
5604342 
Co-authored-by: Marko <marbar3778@yahoo.com>
@faddat faddat mentioned this pull request Mar 20, 2024
Open
12 tasks
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likhita-809 likhita-809 likhita-809 approved these changes

@atheeshp atheeshp atheeshp approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees

@julienrbrt julienrbrt

@testinginprod testinginprod

Labels
C:x/authz
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tac0turtle @julienrbrt @atheeshp @likhita-809 @testinginprod