Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NewCoin takes sdk.Int #1811

Merged
merged 5 commits into from
Jul 31, 2018
Merged

NewCoin takes sdk.Int #1811

merged 5 commits into from
Jul 31, 2018

Conversation

mossid
Copy link
Contributor

@mossid mossid commented Jul 25, 2018 •
edited
Loading

Closes #1723

  • Linked to github-issue with discussion and accepted design
  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Added entries in PENDING.md
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Closes: #1723

@mossid mossid changed the title NewCoins takes sdk.Int NewCoin takes sdk.Int Jul 25, 2018
@mossid mossid force-pushed the joon/1723-newcoin-sdk-int branch from ec67e82 to 64393b3 Compare July 25, 2018 01:01
mossid added a commit that referenced this pull request Jul 25, 2018
@mossid
Merge pull request #1811: NewCoin takes sdk.Int
64393b3 
fix missed code

fix democoin modules
@mossid mossid added the wip label Jul 25, 2018
@mossid mossid changed the title NewCoin takes sdk.Int WIP: NewCoin takes sdk.Int Jul 25, 2018
alexanderbez
alexanderbez reviewed Jul 25, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good so far. Why not have tests just use NewCoin though?

@mossid
Merge pull request #1811: NewCoin takes sdk.Int
cc1bb5d 
fix missed code

fix democoin modules
@mossid mossid force-pushed the joon/1723-newcoin-sdk-int branch from 64393b3 to cc1bb5d Compare July 27, 2018 22:50
@codecov
Copy link

codecov bot commented Jul 27, 2018 •
edited
Loading

Codecov Report

Merging #1811 into develop will decrease coverage by 0.33%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           develop   #1811      +/-   ##
==========================================
- Coverage    63.83%   63.5%   -0.34%     
==========================================
  Files          118     118              
  Lines         7024    7006      -18     
==========================================
- Hits          4484    4449      -35     
- Misses        2285    2301      +16     
- Partials       255     256       +1

@mossid mossid changed the title WIP: NewCoin takes sdk.Int NewCoin takes sdk.Int Jul 28, 2018
cwgoes
cwgoes approved these changes Jul 31, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

@cwgoes cwgoes merged commit 19b0781 into develop Jul 31, 2018
@cwgoes cwgoes deleted the joon/1723-newcoin-sdk-int branch July 31, 2018 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez left review comments

@cwgoes cwgoes cwgoes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mossid @alexanderbez @cwgoes