Bucky/docs #1843
Merged
Bucky/docs #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebuchman
requested review from
cwgoes,
jbibla,
rigelrozanski and
zramsay
as code owners
ebuchman
commented
Jul 26, 2018
| @@ -66,9 +78,13 @@ Fetch the testnet's `genesis.json` file into `gaiad`'s config directory. | |||
|
|
|||
| ```bash | |||
| mkdir -p $HOME/.gaiad/config | |||
| curl https://raw.githubusercontent.com/cosmos/testnets/master/gaia-7002/genesis.json > $HOME/.gaiad/config/genesis.json | |||
| curl https://raw.githubusercontent.com/cosmos/testnets/master/latest/genesis.json > $HOME/.gaiad/config/genesis.json | |||
There was a problem hiding this comment.
need to create this folder!
There was a problem hiding this comment.
just created it but lets add templates to the repo so folks remember to update it !
docs/validators/validator-setup.md
Outdated
| @@ -30,7 +34,7 @@ gaiacli stake create-validator \ | |||
| --pubkey=$(gaiad tendermint show_validator) \ | |||
| --address-validator=<account_cosmosaccaddr> | |||
| --moniker="choose a moniker" \ | |||
| --chain-id=gaia-6002 \ | |||
| --chain-id=gaia-7001 \ | |||
Codecov Report
@@ Coverage Diff @@
## master #1843 +/- ##
=======================================
Coverage 60.63% 60.63%
=======================================
Files 119 119
Lines 6917 6917
=======================================
Hits 4194 4194
Misses 2484 2484
Partials 239 239 |
| * e.g. `cosmosvalpub1zcjduc3qcyj09qc03elte23zwshdx92jm6ce88fgc90rtqhjx8v0608qh5ssp0w94c` | ||
| - Generated when the node is created with `gaiad init`. | ||
| - Get this value with `gaiad tendermint show_validator` | ||
| - e.g. `cosmosvalpub1zcjduc3qcyj09qc03elte23zwshdx92jm6ce88fgc90rtqhjx8v0608qh5ssp0w94c` |
There was a problem hiding this comment.
@zramsay please include a linter for markdown
rigelrozanski
approved these changes
Jul 26, 2018
jbibla
approved these changes
Jul 27, 2018
rigelrozanski
approved these changes
Jul 31, 2018
|
should we merge this to develop not master? or both? - let's merge! (@ebuchman action required) |
rigelrozanski
added
T:Docs
jbibla
reviewed
Aug 1, 2018
docs/sdk/gaiacli.md
Outdated
| @@ -111,13 +113,13 @@ gaiacli stake delegate \ | |||
| --address-delegator=<account_cosmosaccaddr> \ | |||
| --address-validator=$(gaiad tendermint show_validator) \ | |||
| --name=<key_name> \ | |||
| --chain-id=gaia-6002 | |||
| --chain-id=gaia-7002 | |||
zramsay
reviewed
Aug 1, 2018
| @@ -10,26 +10,27 @@ | |||
| 🚧 We are actively working on improving documentation for Gaiacli and Gaiad. | |||
| ::: | |||
There was a problem hiding this comment.
we probably don't need these anymore
zramsay
reviewed
Aug 1, 2018
docs/sdk/clients.md
Outdated
| @@ -141,7 +142,7 @@ gaiacli stake unbond \ | |||
| --address-validator=$(gaiad tendermint show_validator) \ | |||
| --shares=MAX \ | |||
| --name=<key_name> \ | |||
| --chain-id=gaia-6002 | |||
| --chain-id=gaia-7002 | |||
This was referenced Aug 8, 2018
|
@ebuchman why you pushing to deleted branch which is already merged? Has this been merged back to develop yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the docs to point to v0.23/gaia-7002, but also to reduce the amount of hardcoded items.
Mostly what's left is the chain-id in all the CLI commands, but we should be able to remove that soon once we do gaiacli init ...
docs/)PENDING.mdthat include links to the relevant issue or PR that most accurately describes the change.cmd/gaiaandexamples/For Admin Use: