R4R: Query-proposals CLI command #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnya97
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #1845 +/- ##
========================================
Coverage 63.83% 63.83%
========================================
Files 118 118
Lines 7024 7024
========================================
Hits 4484 4484
Misses 2285 2285
Partials 255 255 |
sunnya97
force-pushed
the
sunny/query-proposals-cli
branch
from
cd896a5
to
a28169c
Compare
cwgoes
suggested changes
Jul 27, 2018
|
failed due to: |
|
@alexanderbez did you run a command to make it fail? CI is passing we should integrate in this failing test if so |
|
Did that fail in Gaiad export? There may be an issue with circle CI caching or something there, since it also errored on my PR in #1862. We may want to consider disabling the GaiadExport command or investigating / better logging whats going on there. |
|
@rigelrozanski no I just simply got that from the failed build output. Seems to pass now? |
alexanderbez
force-pushed
the
sunny/query-proposals-cli
branch
from
45f98cd
to
8e7a9dd
Compare
|
Fixed pending changelog. Was @cwgoes comment ever addressed? |
alexanderbez
force-pushed
the
sunny/query-proposals-cli
branch
from
8e7a9dd
to
667b2f4
Compare
alexanderbez
changed the title
|
@cwgoes's request was added |
chillyvee
pushed a commit
to chillyvee/cosmos-sdk
that referenced
this pull request
Mar 1, 2024
* add bech32-convert command to gaiad * add changelog notice * add review fixes * add tests for ConvertBech32Prefix Co-authored-by: Petr Ivanov <petr.ivanov@tendermint.com> Co-authored-by: Danilo Pantani <danpantani@gmail.com> Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/)PENDING.mdthat include links to the relevant issue or PR that most accurately describes the change.cmd/gaiaandexamples/For Admin Use: