-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Query-proposals CLI command #1845
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1845 +/- ##
========================================
Coverage 63.83% 63.83%
========================================
Files 118 118
Lines 7024 7024
========================================
Hits 4484 4484
Misses 2285 2285
Partials 255 255 |
cd896a5
to
a28169c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but can we add a way to start at a nonzero proposal ID - or iterate backwards, e.g. "most recent 5 proposals"?
failed due to: |
@alexanderbez did you run a command to make it fail? CI is passing we should integrate in this failing test if so |
Did that fail in Gaiad export? There may be an issue with circle CI caching or something there, since it also errored on my PR in #1862. We may want to consider disabling the GaiadExport command or investigating / better logging whats going on there. |
@rigelrozanski no I just simply got that from the failed build output. Seems to pass now? |
45f98cd
to
8e7a9dd
Compare
Fixed pending changelog. Was @cwgoes comment ever addressed? |
8e7a9dd
to
667b2f4
Compare
@cwgoes's request was added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
docs/
)PENDING.md
that include links to the relevant issue or PR that most accurately describes the change.cmd/gaia
andexamples/
For Admin Use: