-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add Branch.ExecuteWithGasLimit API #18457
Conversation
WalkthroughWalkthroughA new feature has been introduced to limit the gas consumption during the execution of functions in an isolated context. The Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- core/CHANGELOG.md (1 hunks)
- core/branch/branch.go (2 hunks)
Additional comments: 3
core/CHANGELOG.md (1)
- 37-41: The changelog update correctly reflects the addition of the new
branch.ExecuteWithGasLimit
feature. It's important to ensure that the versioning and release notes will be updated accordingly when the feature is officially released.core/branch/branch.go (2)
9-11: The introduction of a new error variable
ErrGasLimitExceeded
is clear and follows Go's idiomatic way of defining package-level errors. Ensure that this error is handled whereverExecuteWithGasLimit
is called.26-33: The
ExecuteWithGasLimit
function is well-documented, explaining its purpose and behavior. However, it's important to ensure that the implementation of this function correctly measures and limits the gas usage as intended, and that it is thread-safe if the service is expected to be used concurrently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking changeSummary by CodeRabbit
New Features
Documentation
Bug Fixes