fix(server): properly parse multiple gas config

[julienrbrt]

Description

Closes: #18536

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• run make lint and make test
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

Summary by CodeRabbit

• Bug Fixes

  • Resolved a server panic issue related to incorrect minimum gas price configuration.
  • Fixed the use of the correct public key when simulating transactions.
  • Ensured FinalizeBlock calls are now correctly passed to ABCIListeners.
  • Eliminated a data race in BaseApp.getContext as identified by e2e tests.

• Refactor

  • Updated the newApp function to accept new types of application options and streamlined the passing of arguments.

• Documentation

  • Modified the configuration file example to use a comma as the delimiter for specifying minimum gas prices.

• Style

  • Adjusted test function names and expanded test cases to cover new minimum gas price scenarios.

[coderabbitai]

Walkthrough

It looks like you want to generate a summary and a table of changes based on the provided information. Here's the updated content based on your instructions:

Walkthrough

The changes involve bug fixes and refactoring in a Go application related to blockchain or cryptocurrency. A panic issue with gas configuration, a pubkey error in transaction simulation, and a block finalization call issue were fixed. A data race was also resolved. The server's newApp function was refactored to improve the handling of application options. The configuration for minimum gas prices was updated to use a comma delimiter, and the related code and tests were adjusted to reflect this change.

Changes

File(s)	Change Summary
CHANGELOG.md	Fixed server panic, pubkey error in client/tx, block finalization issue, and a data race in baseapp.
server/README.md, simapp/simd/cmd/commands.go	Refactored newApp function to use servertypes.AppOptions and introduced baseappOptions.
server/config/config.go, server/config/config_test.go, server/config/toml.go	Updated minimum gas prices parsing to use a comma delimiter and enhanced related tests.

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• If you reply to a review comment from CodeRabbit, the bot will automatically respond.
• To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
• Note: Review comments are made on code diffs or files, not on the PR overview.
• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 8644e6b and 2d6962b.

Files ignored due to filter (2)

• tools/confix/data/v0.47-app.toml
• tools/confix/data/v0.50-app.toml

Files selected for processing (6)

• CHANGELOG.md (1 hunks)
• server/README.md (1 hunks)
• server/config/config.go (2 hunks)
• server/config/config_test.go (1 hunks)
• server/config/toml.go (1 hunks)
• simapp/simd/cmd/commands.go (1 hunks)

Files skipped from review due to trivial changes (1)

• simapp/simd/cmd/commands.go

Additional comments: 5

CHANGELOG.md (1)

• 70-70:
  The changelog entries are well-documented and include references to the relevant pull requests, which is good for traceability.

server/config/toml.go (1)

• 18-22: The change in the configuration file format from using a semicolon to a comma as the separator for specifying minimum gas prices is correct and aligns with the standard format for multiple values in TOML files. This change should resolve the parsing issue reported in issue [Bug]: Incorrect example to set multiple denoms for mininum-gas-prices #18536.

server/config/config.go (2)

• 3-8: The removal of the "strings" package import is appropriate given that the updated code does not use it.

• 201-215: The GetMinGasPrices function now correctly uses sdk.ParseDecCoins to parse the minimum gas prices. The error handling with a panic is a significant change; ensure that this behavior is documented and that callers are aware that this function can panic.

server/README.md (1)

• 74-84: - The refactoring of the newApp function to accept servertypes.AppOptions instead of server.AppOptions is a significant change. Ensure that all references to this function are updated accordingly.

• The introduction of baseappOptions as variadic arguments to simapp.NewSimApp is a good practice for flexibility and maintainability.
• Verify that the DefaultBaseappOptions function correctly extracts the necessary options from appOpts and that the simapp.NewSimApp function is compatible with the variadic baseappOptions parameter.
• Ensure that the documentation reflects the correct usage of the new function signature and the rationale behind the changes.

[coderabbitai]

The test cases in TestGetAndSetMinimumGas have been updated to include scenarios with multiple minimum gas prices. However, the assertions for cfg.MinGasPrices are directly comparing the string representation of DecCoins which might not be robust if the string representation changes in the future. It would be better to compare DecCoins directly.

- require.Equal(t, "5.000000000000000000foo", cfg.MinGasPrices)
+ require.EqualValues(t, input.String(), cfg.MinGasPrices)
- require.Equal(t, "1.000000000000000000bar,5.000000000000000000foo", cfg.MinGasPrices)
+ require.EqualValues(t, input.String(), cfg.MinGasPrices)

---

Commitable suggestion

[!IMPORTANT]
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

	func TestGetAndSetMinimumGas(t *testing.T) {
	cfg := DefaultConfig()
	cfg.SetMinGasPrices(sdk.DecCoins{sdk.NewInt64DecCoin("foo", 5)})
	input := sdk.DecCoins{sdk.NewInt64DecCoin("foo", 5)}
	cfg.SetMinGasPrices(input)
	require.Equal(t, "5.000000000000000000foo", cfg.MinGasPrices)
	require.EqualValues(t, cfg.GetMinGasPrices(), input)
	input = sdk.DecCoins{sdk.NewInt64DecCoin("bar", 1), sdk.NewInt64DecCoin("foo", 5)}
	cfg.SetMinGasPrices(input)
	require.Equal(t, "1.000000000000000000bar,5.000000000000000000foo", cfg.MinGasPrices)
	require.EqualValues(t, cfg.GetMinGasPrices(), input)
	}
	func TestGetAndSetMinimumGas(t *testing.T) {
	cfg := DefaultConfig()
	input := sdk.DecCoins{sdk.NewInt64DecCoin("foo", 5)}
	cfg.SetMinGasPrices(input)
	require.EqualValues(t, input.String(), cfg.MinGasPrices)
	require.EqualValues(t, cfg.GetMinGasPrices(), input)
	input = sdk.DecCoins{sdk.NewInt64DecCoin("bar", 1), sdk.NewInt64DecCoin("foo", 5)}
	cfg.SetMinGasPrices(input)
	require.EqualValues(t, input.String(), cfg.MinGasPrices)
	require.EqualValues(t, cfg.GetMinGasPrices(), input)
	}

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 2d6962b and 28da976.

Files selected for processing (1)

• CHANGELOG.md (1 hunks)

Additional comments: 1

CHANGELOG.md (1)

• 70-70:
  The changelog entries are well-documented and include references to the relevant pull requests, which is good for traceability.