-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix typos in UPGRADING.md #18613
Conversation
WalkthroughWalkthroughThe Cosmos SDK has undergone significant updates to enhance modularity and usability. Key changes include the abstraction from CometBFT types, streamlining event emission, simplifying parameter store settings, and deprecating the Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- UPGRADING.md (5 hunks)
Additional comments: 6
UPGRADING.md (6)
150-156: The summary provided does not match the PR objective, which is to fix a typographical error in the UPGRADING.md file. The summary instead details extensive changes to the Cosmos SDK, which is not aligned with the PR objective of correcting a typo.
150-156: The changes in this hunk correctly reflect the abstraction from CometBFT Go types, including the replacement of the CometBFT logger with the Cosmos SDK logger interface and the
github.com/cometbft/cometbft/libs/bytes.HexByte
with[]byte
.780-786: The removal of boilerplate code for emitting
EventTypeMessage
events withsdk.AttributeKeyModule
andsdk.AttributeKeySender
is correctly implemented in this hunk.909-912: The addition of the
x/protocolpool
store during an upgrade to v0.51.x is correctly implemented in this hunk.1000-1005: The deprecation of the
x/params
module and the recommendation for migrating modules away from using it are correctly documented in this hunk.1037-1040: The requirement for clients to set a codec when interacting with a node via
grpc.Dial
is correctly documented in this hunk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
(cherry picked from commit 96df84f) # Conflicts: # UPGRADING.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wkn
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
Documentation
Refactor
Deprecations
x/params
module.New Requirements
grpc.Dial
to interact with nodes.