update signing info endpoint #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 30, 2018 22:24
…nstead of cosmosvaladdr for consistencyu reasons
joe-bowman
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
joe-bowman
force-pushed
the
1816-update-signing-info-endpoint
branch
from
13c7c8a
to
6782672
Compare
|
Thanks for the PR; see #1866 (comment). I'm still OK with merging this for now, but we should leave the issue open, and note that the REST endpoints may need to change in the future. |
Codecov Report
@@ Coverage Diff @@
## develop #1889 +/- ##
========================================
Coverage 63.83% 63.83%
========================================
Files 118 118
Lines 7024 7024
========================================
Hits 4484 4484
Misses 2285 2285
Partials 255 255 |
|
Fixed merge conflict with develop. |
Thanks; merged. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/) - (/slashing/signing-info endpoint does not appear to exist in spec, or api docs)PENDING.mdthat include links to the relevant issue or PR that most accurately describes the change.cmd/gaiaandexamples/As discussed in #1866, REST endpoint
/slashing/signing-info/{ validator }should takecosmosValPubrather than existingcosmosVallAddrin order to maintain consistency between REST and CLI interfaces.For Admin Use: