revert: test(client) wrap cmd.SetArgs to fix bugs for cmd.SetArgs (#18876)

[levisyin]

This reverts commit ae19acc. #18876

Description

I just found the bug of the implementation of SetArgs in internal/testutil, it would get unexpected default value when the flag field type is SliceValue(Append instead of replace). See detail info in comment.

If spf13/cobra won't support for Reset() error feature, I will choose another way to implement this. But for now, I think it would be better to revert commit first.

Sorry about this, I didn't cover a full test for wrapped SetArgs.

[coderabbitai]

Walkthrough

The overall change involves updating a Go test file to refine how command arguments are set for testing. The update replaces an internal utility function with a command method for argument handling and makes adjustments to flag settings. These changes are aimed at improving the test setup for a specific command function without altering any public or exported entities.

Changes

File Path	Change Summary
client/keys/show_test.go	Replaced internaltestutil.SetArgs with cmd.SetArgs and updated flag handling for runShowCmd tests.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your comments unless it is explicitly tagged.

• You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
  • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[julienrbrt]

Ok, so we are waiting for changes in cobra instead, if i understand correctly right?

[levisyin]

Ok, so we are waiting for changes in cobra instead, if i understand correctly right?

Yep, I will try my best to promote it. If spf13/cobra won't accept it, I will try my best to find another convenient way to wrap the SetArgs.