Add note about checking spec to the PR template #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackzampolin
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #1898 +/- ##
==========================================
Coverage ? 63.83%
==========================================
Files ? 118
Lines ? 7024
Branches ? 0
==========================================
Hits ? 4484
Misses ? 2285
Partials ? 255 |
cwgoes
approved these changes
Aug 1, 2018
There was a problem hiding this comment.
utACK
That said, I don't think this really addresses the problem as discussed in the retro - the reviewer just reading the spec isn't enough (or doesn't appear to have been); we need some sort of "deep review" process by which the reviewer(s) can really reason through the logic and catch edge cases that the author might have missed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a quick note about checking the Spec to the PR template. I added to an existing item.