fix(x/gov)!: backport of PR #18146: min amount per deposit #19312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSalopek
changed the title
|
Looking at tests EDIT: |
mpoke
approved these changes
Jan 31, 2024
MSalopek
force-pushed
the
masa/backport-18146-min-amount-per-deposit
branch
from
76768d5
to
97faf4f
Compare
Merged
19 tasks
czarcas7ic
added a commit
to osmosis-labs/cosmos-sdk
that referenced
this pull request
Mar 22, 2024
…#19312) (#510) * feat(x/gov): implement a minimum amount per deposit (cosmos#18146) Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * Fix * Fix test * Fix e2e * Fix e2e * Fix test * update changelog * Include expedited proposal logic * Update deposit.go --------- Co-authored-by: MSalopek <matija.salopek994@gmail.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Adam Tucker <adam@osmosis.team> Co-authored-by: Adam Tucker <adamleetucker@outlook.com>
czarcas7ic
added a commit
to osmosis-labs/cosmos-sdk
that referenced
this pull request
Mar 25, 2024
…cosmos#19312) (#510)" This reverts commit 106ba23.
czarcas7ic
added a commit
to osmosis-labs/cosmos-sdk
that referenced
this pull request
Mar 25, 2024
…cosmos#19312) (#510)" This reverts commit 106ba23.
czarcas7ic
added a commit
to osmosis-labs/cosmos-sdk
that referenced
this pull request
Mar 25, 2024
…cosmos#19312) (#510)" This reverts commit 106ba23.
tbruyelle
pushed a commit
to atomone-hub/atomone
that referenced
this pull request
Sep 17, 2024
Backport of cosmos/cosmos-sdk#19312 Co-authored-by: Adam Hanna <ahanna@mines.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport: #18146
Minor changes were introduced where the interfaces don't match.
Minor changes in testing (gas calculations in operations_test.go)
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...