Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: Reduce size of TestImmutability<Arith\U>Int tests #1936

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

ValarDragon
Copy link
Contributor

@ValarDragon ValarDragon commented Aug 8, 2018

Currently they take ~1 minute on circle CI. There isn't a significant reason
for this to delay all our tests. This commit reduces the time spent on these
tests by a factor of 20.

  • Added entries in PENDING.md that include links to the relevant issue or PR that most accurately describes the change. - not user facing

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Currently they take ~1 minute on circle CI. There isn't a significant reason
for this to delay all our tests. This commit reduces the time spent on these
tests by a factor of 20.
@ValarDragon
Copy link
Contributor Author

Now the time spent in types is ok github.com/cosmos/cosmos-sdk/types 4.303s coverage: 82.6% of statements, way better than the previous 1 minute :)

@codecov
Copy link

codecov bot commented Aug 8, 2018

Codecov Report

Merging #1936 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1936   +/-   ##
========================================
  Coverage    64.71%   64.71%           
========================================
  Files          114      114           
  Lines         6782     6782           
========================================
  Hits          4389     4389           
  Misses        2114     2114           
  Partials       279      279

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, thanks!

@cwgoes cwgoes merged commit 10199c9 into develop Aug 8, 2018
@cwgoes cwgoes deleted the dev/reduce_test_length branch August 8, 2018 10:05
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants