Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(x/staking): migrate to use env #19414
refactor(x/staking): migrate to use env #19414
Changes from all commits
c8a8d82
864e881
c00c3ba
96ba789
a5a2e92
f1da81d
a3a8f4b
7a78ba2
643c603
89752e2
1e57d2c
74708c9
3ada1ab
bac20cf
173f1b4
66f2128
c1790e2
d3bebcd
dd203e9
f5a7068
b3149ca
76a9e83
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding assertions after each slashing operation to verify the expected state changes, not just at the end of the test. This will help ensure each step of the test behaves as expected and makes the test more robust.
Repeated slashing operations in the test are intended to simulate different scenarios. However, ensure there's clear documentation or comments explaining the rationale behind each operation and what specific condition or behavior it's testing. This will improve the maintainability and readability of the test.
The final assertions in the test verify the expected outcomes of the slashing operations, including the validator's power and the balances of the bonded and not bonded pools. These assertions are crucial for ensuring the slashing logic is correctly implemented. However, consider adding more granular assertions throughout the test to verify intermediate states after each significant operation.
The test function
TestSlashWithUnbondingDelegation
effectively covers the scenario it's designed to test. However, consider adding tests for edge cases, such as slashing with a fraction of zero or more than one, and cases where the unbonding delegation or validator does not exist. Expanding test coverage in this way can help ensure the robustness of the slashing logic under various conditions.