Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gblue1223/basecoin fix #1942

Merged
merged 3 commits into from
Aug 8, 2018
Merged

Gblue1223/basecoin fix #1942

merged 3 commits into from
Aug 8, 2018

Conversation

ValarDragon
Copy link
Contributor

This copies @gblue1223's PR #1919, and rebases onto develop. @gblue1223, so sorry about all the confusion, we should have just asked you to rebase. I've just cherry-picked your commits onto this branch, so you'll have the commit history :)

Checkboxes were taken care of in #1919


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 8, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@1da1115). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #1942   +/-   ##
==========================================
  Coverage           ?   64.71%           
==========================================
  Files              ?      114           
  Lines              ?     6782           
  Branches           ?        0           
==========================================
  Hits               ?     4389           
  Misses             ?     2114           
  Partials           ?      279

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants