Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename stake Validator.Owner -> .Operator #1950

Merged
merged 3 commits into from
Aug 16, 2018
Merged

Rename stake Validator.Owner -> .Operator #1950

merged 3 commits into from
Aug 16, 2018

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Aug 9, 2018

  • [cli] Flag --address-validator renamed to --validator
  • [types] Validator interface's GetOwner() renamed to GetOperator()
  • [x/stake] Validator.Owner renamed to Validator.Operator

Relevant issue: #1901

alexanderbez
alexanderbez approved these changes Aug 9, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 (hopefully I didn't miss anything :-p)

cwgoes
cwgoes approved these changes Aug 10, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

rigelrozanski
rigelrozanski approved these changes Aug 10, 2018
View reviewed changes
Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lookin' gud

@rigelrozanski
Copy link
Contributor

what's with waiting for this linter to pass? maybe we should merge to a cosmos branch then merge in to develop from there?

@alexanderbez
Copy link
Contributor

maybe we should merge to a cosmos branch then merge in to develop from there?

Why's that?

@rigelrozanski
Copy link
Contributor

because we've been waiting for the CI linter to run for a long long time

@ebuchman
Copy link
Member

Waiting until after v0.24

@ValarDragon
Copy link
Contributor

I'm very confused as to why setup_dependencies hasn't ended. It looks as though that job never got started? (Theres no details button).

melekes
melekes reviewed Aug 14, 2018
View reviewed changes
docs/spec/staking/transactions.md
@@ -28,74 +28,74 @@ A validator is created using the `TxCreateValidator` transaction.

```golang
type TxCreateValidator struct {
OwnerAddr sdk.Address
Operator sdk.Address
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting is off

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings are same length:

alessio@bizet:~$ [ `echo "OwnerAddr           sdk.Address" | wc -m` = `echo "Operator            sdk.Address" | wc -m` ] && echo OK || echo KO
OK

Perhaps I misunderstood though.

x/stake/types/validator.go Outdated
var storeValue validatorValue
err = cdc.UnmarshalBinary(value, &storeValue)
if err != nil {
return
}

if len(ownerAddr) != 20 {
if len(operatorAddr) != 20 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

magic number

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @melekes is suggesting this should be a constant -- correct me if I'm wrong ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think he is. @melekes could you elaborate please?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @alexanderbez said ^^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being addressed in #1997

@rigelrozanski
Copy link
Contributor

ugh failing because of non-determinism - @alessio want to re-run test_cover?

@alexanderbez
Copy link
Contributor

Hmmm, strange...

unused CommitStoreLoader: KVStoreKey{0xc420c34100, params}

@rigelrozanski
Copy link
Contributor

Yeah I've seen this one a bunch is it not the same as the other nondeterministic test failure?

@ValarDragon
Copy link
Contributor

That is the normal non-deterministic test failure on test_cover. Is there an open issue for it yet?

@rigelrozanski rigelrozanski mentioned this pull request Aug 15, 2018
Closed
@rigelrozanski
Copy link
Contributor

@ValarDragon just made one (it didn't exist as far as I could tell) - also introduced a non-determinism issue label

@alexanderbez
Copy link
Contributor

Strange -- no, I don't think so @ValarDragon

@alessio
Copy link
Contributor Author

alessio commented Aug 16, 2018

Rebased on develop. make test_cover has gone through smoothly this time.

@faboweb
Copy link
Contributor

faboweb commented Aug 16, 2018

@cosmos/cosmos-ui breaking

@alexanderbez alexanderbez added T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). T: UX labels Aug 16, 2018
@alexanderbez
Copy link
Contributor

@faboweb I'm trying to add the Breaking label where appropriate to help out filtering these changes 👍

@rigelrozanski rigelrozanski merged commit 187bc19 into cosmos:develop Aug 16, 2018
@alessio alessio deleted the alessio/1901-owner-operator-renaming branch August 16, 2018 22:38
@alessio alessio mentioned this pull request Aug 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@melekes melekes melekes left review comments

@cwgoes cwgoes cwgoes approved these changes

@rigelrozanski rigelrozanski rigelrozanski approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@zramsay zramsay Awaiting requested review from zramsay

Assignees
No one assigned
Labels
C:x/staking T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). T: UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@alessio @rigelrozanski @alexanderbez @ebuchman @ValarDragon @faboweb @melekes @cwgoes