Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove dependency x/module -> sdk through InterfaceRegistry #19652

Merged
merged 7 commits into from
Mar 6, 2024
Merged

refactor: remove dependency x/module -> sdk through InterfaceRegistry #19652

merged 7 commits into from
Mar 6, 2024

Commits on Mar 5, 2024

  1. refactor: remove dependency x/module -> sdk in InterfaceRegistry 

    - refactor modules to use core/registry/LegacyRegistry
- update `HasRegisterInterfaces` definition
- fix core_module.go usage
- rm unused import in mock code
- cd simapp/v2 && go mod tidy
- mv HasRegisterInterfaces interface to core
- fix failing test to conform with mock
- use protoiface.MessageV1 in interface registry
    @kocubinski
    kocubinski committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    f127cd4 View commit details
    Browse the repository at this point in the history

  2. revert types/module/module_test.go

    @kocubinski
    kocubinski committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    accfd5b View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. add notes to CHANGELOG and UPGRADING

    @kocubinski
    kocubinski committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    650c4c3 View commit details
    Browse the repository at this point in the history

  2. alias types/module.HasRegisterInterfaces -> core

    @kocubinski
    kocubinski committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    3ac22fe View commit details
    Browse the repository at this point in the history

  3. fix typo

    @kocubinski
    kocubinski committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    719c840 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into kocubinski/refactor-iface-reg

    @kocubinski
    kocubinski committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    7a5c350 View commit details
    Browse the repository at this point in the history

  5. lint fix

    @kocubinski
    kocubinski committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    1e2ce43 View commit details
    Browse the repository at this point in the history