Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networks: clean up & some fixes to prepare for docs #1986

Merged
merged 4 commits into from
Aug 11, 2018

Conversation

zramsay
Copy link
Contributor

@zramsay zramsay commented Aug 11, 2018

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Added entries in PENDING.md that include links to the relevant issue or PR that most accurately describes the change.
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 11, 2018

Codecov Report

Merging #1986 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1986   +/-   ##
========================================
  Coverage    64.86%   64.86%           
========================================
  Files          114      114           
  Lines         6837     6837           
========================================
  Hits          4435     4435           
  Misses        2120     2120           
  Partials       282      282

@rigelrozanski rigelrozanski merged commit 69dd371 into develop Aug 11, 2018
@zramsay zramsay deleted the zach/t-and-a branch August 11, 2018 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants