feat(runtime/v2): Export Genesis #20009
Conversation
|
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
@hieuvubk your pull request is missing a changelog! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
julienrbrt
changed the title
There was a problem hiding this comment.
This approach conflicts with work in #20076 which takes a different approach. Tangibly this PR will panic at this site https://github.com/cosmos/cosmos-sdk/blob/server_modular/runtime/v2/app.go#L134-L136 since ExecuteGenesisTx is not implemented (and probably shouldn't be in v2) on runtime/v2.App.
We should decide which approach we want to take first so I'm requesting changes for now.
| for moduleName := range channels { | ||
| res := <-channels[moduleName] | ||
| if res.err != nil { | ||
| return nil, fmt.Errorf("genesis export error in %s: %w", moduleName, res.err) |
There was a problem hiding this comment.
🤔 would it make sense to collect all error messages instead and return them together? It is also ok to fail fast on first error. You could cancel the context in this case (ctx, cancel := context.WithCancel(ctx)) (assuming the modules would abort) and exit the Go routines early, too.
|
|
||
| genesisData := make(map[string]json.RawMessage) | ||
| for moduleName := range channels { | ||
| res := <-channels[moduleName] |
There was a problem hiding this comment.
nit: this is blocking on the first channel in the map. If you would move the module name into the genesisResult, you can have a channel just for the results instead that would be a fifo. Not sure if this gives some significant performance benefit or makes it harder to read. 🤷
| ch <- genesisResult{jm, nil} | ||
| }(module, channels[moduleName]) | ||
| } | ||
| } |
There was a problem hiding this comment.
Modules that do not implement the export method are silently ignored. Would some log output make sense?
There was a problem hiding this comment.
All mandatory modules are present and checked by assertNoForgottenModules.
I'd rather have assertNoForgottenModules panic when unnecessary modules are present than adding extra log personally.
We have relaxed the required modules in the previous sdk release, but you could still add modules to say OrderBeginBlock that don't implement BeginBlocker, and it will be silently skipped. Given this is a green field, imho best to have assertNoForgottenModules more pedantic in this new module manager.
tac0turtle
changed the title
Description
Closes: #19244
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...