Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulate transactions by default to set gas automatically #2047

Merged
merged 10 commits into from
Aug 28, 2018
Merged

Simulate transactions by default to set gas automatically #2047

merged 10 commits into from
Aug 28, 2018

Commits on Aug 24, 2018

  1. Simulate transactions before actual execution 

    * Change --gas=0 semantic in order to enable gas auto estimate.
* REST clients have been modified to simulate the execution of
  the tx first to then populate the context with the estimated
  gas amount returned by the simulation.
* The simulation returns both an unadjusted gas estimate and an
  adjusted one. The adjustment is required to ensure that the
  ensuing execution doesn't fail due to state changes that might
  have occurred. Gas adjustment can be controlled via the CLI's
  --gas-adjustment flag.
* Tiny refactorig of REST endpoints error handling.

Closes: #1246
    @alessio
    alessio committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    f432c0c View commit details
    Browse the repository at this point in the history

  2. Update PENDING.md

    @alessio
    alessio committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    323fac3 View commit details
    Browse the repository at this point in the history

  3. Add/refresh docs

    @alessio
    alessio committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    47d55bd View commit details
    Browse the repository at this point in the history

  4. comment getContextForAnte(), rename applyTxMode()

    @alessio
    alessio committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    e959478 View commit details
    Browse the repository at this point in the history

  5. clarifyy that adjustment is a multiplicative factor

    @alessio
    alessio committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    7e9ceb4 View commit details
    Browse the repository at this point in the history

  6. TestCoinSend: test success case when setting gas by hand

    @alessio
    alessio committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    2dea467 View commit details
    Browse the repository at this point in the history

  7. simplify json handling in LCD tests

    @alessio
    alessio committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    fb5fe99 View commit details
    Browse the repository at this point in the history

  8. Incorporating @ValarDragon's comments

    @alessio
    alessio committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    f36f749 View commit details
    Browse the repository at this point in the history

  9. Incorporating @cwgoes comments

    @alessio
    alessio committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    7e8feec View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2018

  1. Modify AnteHandler to take a simulate boolean parameter

    @alessio
    alessio committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    76a16ab View commit details
    Browse the repository at this point in the history