Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(proto): change future extracted modules version from v1.0.0 to v0.2.0 #20600

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jun 7, 2024

Description

We won't manage to totally remove the SDK imports for this release, so we'll stick with 0ver until the SDK dep is gone.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Updates
    • Downgraded version references from v1.0.0 to v0.2.0 in various protocol buffer definitions across multiple modules.

These changes ensure compatibility with earlier versions, improving integration flexibility with other systems.

@julienrbrt julienrbrt requested a review from a team as a code owner June 7, 2024 20:41
Copy link
Contributor

coderabbitai bot commented Jun 7, 2024

Walkthrough

Walkthrough

The changes primarily involve downgrading version numbers from v1.0.0 to v0.2.0 or updating them to v1.2.0 in various protobuf and Go files related to the Cosmos SDK. These modifications affect byte array definitions, protobuf raw descriptors, and version compatibility annotations for messages and RPCs.

Changes

File Path Change Summary
api/cosmos/authz/v1beta1/tx.pulsar.go Altered version number in byte array definition from v1.0.0 to v0.2.0.
api/cosmos/gov/v1/gov.pulsar.go Updated protobuf raw descriptor version numbers from v1.0.0 to v0.2.0.
api/cosmos/gov/v1/query.pulsar.go Changed version numbers in byte array from v1.0.0 to v1.2.0.
api/cosmos/gov/v1/tx.pulsar.go Modified version number in cosmos.gov.v1.ProposalType field from v1.0.0 to v1.2.0.
x/authz/proto/cosmos/authz/v1beta1/tx.proto Downgraded cosmos_proto.message_added_in for MsgPruneExpiredGrants and MsgPruneExpiredGrantsResponse from v1.0.0 to v0.2.0.
x/gov/proto/cosmos/gov/v1/gov.proto Downgraded version references for ProposalType, ProposalVoteOptions, and Params from v1.0.0 to v0.2.0.
x/gov/proto/cosmos/gov/v1/query.proto Changed cosmos_proto.method_added_in for ProposalVoteOptions and MessageBasedParams RPCs from v1.0.0 to v0.2.0.
x/gov/proto/cosmos/gov/v1/tx.proto Updated proposal_type field's version compatibility annotation from v1.0.0 to v0.2.0.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ca14b28 and 76a7bec.

Files ignored due to path filters (4)
  • x/authz/tx.pb.go is excluded by !**/*.pb.go
  • x/gov/types/v1/gov.pb.go is excluded by !**/*.pb.go
  • x/gov/types/v1/query.pb.go is excluded by !**/*.pb.go
  • x/gov/types/v1/tx.pb.go is excluded by !**/*.pb.go
Files selected for processing (8)
  • api/cosmos/authz/v1beta1/tx.pulsar.go (1 hunks)
  • api/cosmos/gov/v1/gov.pulsar.go (4 hunks)
  • api/cosmos/gov/v1/query.pulsar.go (2 hunks)
  • api/cosmos/gov/v1/tx.pulsar.go (1 hunks)
  • x/authz/proto/cosmos/authz/v1beta1/tx.proto (1 hunks)
  • x/gov/proto/cosmos/gov/v1/gov.proto (3 hunks)
  • x/gov/proto/cosmos/gov/v1/query.proto (1 hunks)
  • x/gov/proto/cosmos/gov/v1/tx.proto (1 hunks)
Files skipped from review due to trivial changes (2)
  • api/cosmos/gov/v1/query.pulsar.go
  • x/gov/proto/cosmos/gov/v1/query.proto
Additional context used
Path-based instructions (3)
api/cosmos/authz/v1beta1/tx.pulsar.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

api/cosmos/gov/v1/gov.pulsar.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

api/cosmos/gov/v1/tx.pulsar.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (13)
x/authz/proto/cosmos/authz/v1beta1/tx.proto (2)

109-109: Version annotation downgrade from v1.0.0 to v0.2.0 in MsgPruneExpiredGrants.

This change aligns with the PR's objective to adjust the versioning in anticipation of future module extractions.


117-117: Version annotation downgrade from v1.0.0 to v0.2.0 in MsgPruneExpiredGrantsResponse.

This version change is consistent with the downgrade in MsgPruneExpiredGrants, ensuring consistency across related message types.

x/gov/proto/cosmos/gov/v1/tx.proto (1)

101-101: Version annotation downgrade from v1.0.0 to v0.2.0 in MsgSubmitProposal.

The version downgrade reflects the PR's goal to adjust versioning in the governance module, aligning with the broader strategy of version management before SDK dependencies are removed.

x/gov/proto/cosmos/gov/v1/gov.proto (4)

133-133: Version annotation downgrade from v1.0.0 to v0.2.0 in ProposalType within Proposal.

This change is part of the systematic version downgrades across the governance module, ensuring that all components reflect the new version strategy.


160-160: Version annotation downgrade from v1.0.0 to v0.2.0 in ProposalVoteOptions.

This update ensures that the version annotations are consistent across the governance module, aligning with the changes made in other parts of the module.


327-327: Multiple version annotation downgrades in Params.

These changes are consistent with the PR's objectives and reflect a broader strategy to manage versions more conservatively until SDK dependencies are fully resolved.

Also applies to: 332-332, 337-337, 341-341, 345-345


352-352: Version annotation downgrade in MessageBasedParams.

This change aligns with the consistent version management strategy across the governance module, ensuring that all new features and updates reflect the revised versioning approach.

api/cosmos/authz/v1beta1/tx.pulsar.go (1)

4893-4897: Version downgrade from v1.0.0 to v0.2.0 correctly implemented in the byte array.

api/cosmos/gov/v1/gov.pulsar.go (4)

10426-10426: Version downgrade from v1.0.0 to v0.2.0 aligns with PR objectives.


10440-10440: Version downgrade from v1.0.0 to v0.2.0 aligns with PR objectives.


10592-10599: Version downgrade from v1.0.0 to v0.2.0 aligns with PR objectives.


10636-10636: Version downgrade from v1.0.0 to v0.2.0 aligns with PR objectives.

api/cosmos/gov/v1/tx.pulsar.go (1)

11132-11132: Version annotation updated correctly from v1.0.0 to v0.2.0 for ProposalType.

@julienrbrt julienrbrt added this pull request to the merge queue Jun 10, 2024
Merged via the queue into main with commit 7fb2668 Jun 10, 2024
67 of 69 checks passed
@julienrbrt julienrbrt deleted the julien/protos branch June 10, 2024 10:20
alpe added a commit that referenced this pull request Jun 12, 2024
* main:
  refactor(x/auth): Fix system test (#20531)
  feat(crypto): add blst (#20296)
  docs: Update high level overview and introduction (#20535)
  refactor(x/core): remove test (#20624)
  feat(x/mint)!: Replace InflationCalculationFn with MintFn + simple epoch minting (#20363)
  docs: remove duplicate words (#20622)
  feat: prep for errors v2 (#20539)
  chore: reduce default inflation (#20606)
  refactor(store): add miss defer (#20602)
  chore: use comet api pkg instead of comet alias (#20614)
  chore: write gentx info to cmd.ErrOrStderr (#20616)
  docs: ADR 073: update to accepted and add to README.md (#20619)
  chore(proto): change future extracted modules version from v1.0.0 to v0.2.0 (#20600)
  fix: remove some duplicate words (#20605)
  feat(stf): port simappv2 changes (#20587)
  chore: bring patch changelogs to main (#20599)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants