Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run localnet on every commit ensure network reaches at least 10 blocks #2067

Merged
merged 3 commits into from
Aug 16, 2018

Conversation

jackzampolin
Copy link
Member

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Added entries in PENDING.md that include links to the relevant issue or PR that most accurately describes the change.

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 16, 2018

Codecov Report

Merging #2067 into release/v0.24.0 will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release/v0.24.0    #2067   +/-   ##
================================================
  Coverage            63.81%   63.81%           
================================================
  Files                  113      113           
  Lines                 6665     6665           
================================================
  Hits                  4253     4253           
  Misses                2129     2129           
  Partials               283      283

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, thanks!

@cwgoes cwgoes merged commit 45bd414 into release/v0.24.0 Aug 16, 2018
@cwgoes cwgoes deleted the jack/release-ci branch August 16, 2018 18:24
zramsay added a commit to tendermint/tendermint that referenced this pull request Aug 26, 2018
zramsay added a commit to tendermint/tendermint that referenced this pull request Aug 26, 2018
melekes pushed a commit to tendermint/tendermint that referenced this pull request Sep 5, 2018
* tests: use make localnet

based on @jackzampolin work in:
cosmos/cosmos-sdk#2067

* keep the p2p tests for now

* fixes after my own review

* nohup

* remove nohup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants