Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(x/staking,x/auth): regenerate mock to fix test #20684

Merged
merged 1 commit into from
Jun 17, 2024
Merged

fix(x/staking,x/auth): regenerate mock to fix test #20684

merged 1 commit into from
Jun 17, 2024
+32 −0

Conversation

Halimao
Copy link
Contributor

@Halimao Halimao commented Jun 17, 2024 •
edited by coderabbitai bot
Loading

Description

Error: keeper/keeper_test.go:87:50: cannot use ck (variable of type *"cosmossdk.io/x/staking/testutil".MockConsensusKeeper) as "cosmossdk.io/x/consensus/types".QueryServer value in argument to consensustypes.RegisterQueryServer: *"cosmossdk.io/x/staking/testutil".MockConsensusKeeper does not implement "cosmossdk.io/x/consensus/types".QueryServer (missing method GetCometInfo)
FAIL	cosmossdk.io/x/staking/keeper [build failed]

Regenerate mocks to fix test failed issue

Summary by CodeRabbit

  • New Features
    • Introduced the ability to retrieve comet information through the new GetCometInfo method in the ConsensusKeeper interface.

@Halimao Halimao requested a review from a team as a code owner June 17, 2024 03:15
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 17, 2024 •
edited
Loading

Walkthrough

Walkthrough

The recent changes introduce a new method, GetCometInfo, to the ConsensusKeeper interface across various modules. This addition allows the system to retrieve comet information as part of its consensus operations. Alongside, mock methods for testing the GetCometInfo function are also implemented to ensure robustness and correctness in testing scenarios.

Changes

Files Change Summary
x/auth/ante/expected_keepers.go Added GetCometInfo method to the ConsensusKeeper interface.
x/auth/ante/testutil/expected_keepers_mocks.go Added GetCometInfo and its mock recorder method to MockConsensusKeeper.
x/staking/testutil/expected_keepers_mocks.go Added GetCometInfo and its mock recorder method to MockConsensusKeeper.
x/staking/types/expected_keepers.go Added GetCometInfo method to the ConsensusKeeper interface.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Halimao Halimao changed the title fix(x/staking,x/auth): regenrate mock to fix test fix(x/staking,x/auth): regenerate mock to fix test Jun 17, 2024
coderabbitai[bot]
coderabbitai bot reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d21620d and de4f062.

Files selected for processing (4)
  • x/auth/ante/expected_keepers.go (1 hunks)
  • x/auth/ante/testutil/expected_keepers_mocks.go (1 hunks)
  • x/staking/testutil/expected_keepers_mocks.go (1 hunks)
  • x/staking/types/expected_keepers.go (1 hunks)
Additional context used
Path-based instructions (4)
x/auth/ante/expected_keepers.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

x/staking/types/expected_keepers.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

x/auth/ante/testutil/expected_keepers_mocks.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

x/staking/testutil/expected_keepers_mocks.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (4)
x/auth/ante/expected_keepers.go (1)

33-33: Added GetCometInfo method to ConsensusKeeper interface. Ensure that all implementations of this interface are updated accordingly.

x/staking/types/expected_keepers.go (1)

121-121: Added GetCometInfo method to ConsensusKeeper interface consistent with changes in other modules.

x/auth/ante/testutil/expected_keepers_mocks.go (1)

198-211: Properly implemented mock for GetCometInfo in MockConsensusKeeper. Ensure that tests using this mock properly simulate and assert the behavior of the GetCometInfo method.

x/staking/testutil/expected_keepers_mocks.go (1)

768-781: Consistent implementation of GetCometInfo mock across modules. This consistency helps maintain uniformity in testing practices.

@julienrbrt julienrbrt added this pull request to the merge queue Jun 17, 2024
Merged via the queue into cosmos:main with commit 6ee21af Jun 17, 2024
70 of 71 checks passed
@Halimao Halimao deleted the fix/mock branch June 17, 2024 05:23
alpe added a commit that referenced this pull request Jun 17, 2024
@alpe
Merge branch 'main' into alex/sims_runner
b74ab29 
* main:
  feat(tx): port simappv2 changes (#20648)
  build(deps): Bump github.com/spf13/cobra from 1.8.0 to 1.8.1 (#20682)
  chore(proto): fix comments (#20679)
  (serverv2/cometbft) Commands support both json and yaml output (#20670)
  fix(x/staking,x/auth):  regenerate mock to fix test (#20684)
  docs: ADR 074: Msg v2 (#20618)
  fix: nested multisig signatures using CLI (#20438)
  chore: fix spelling errors (#20674)
  fix: align Dockerfile for build-push-action (#20672)
  fix: avoid build fail when make localnet-build-env (#20671)
  build(deps): Bump bufbuild/buf-setup-action from 1.32.2 to 1.33.0 (#20669)
  chore: make function comment match function names (#20666)
  chore(consensus): add cometInfo to consensus  (#20615)
  chore: fix typos (#20662)
  fix: Properly parse json in the wait-tx command. (#20631)
  fix(sims): check before sending RotateConsPubKey (#20659)
  test(types/address): add unit tests for the file types/address.go  (#20237)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@sontrinh16 sontrinh16 sontrinh16 approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

Assignees
No one assigned
Labels
C:x/auth C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Halimao @julienrbrt @sontrinh16