feat(math): Upstream GDA based decimal type testing #20763

samricotta · 2024-06-24T16:35:38Z

Description

These are the last changes to be made to finish the testing for the apd library. Here I focused on the remaining functions as well as cleanup.

Here I concentrated on the constraints of the decimal and tried to push the boundaries so we can see how far the precision goes.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

included the correct type prefix in the PR title, you can find examples of the prefixes below:
confirmed ! in the type prefix if API or client breaking change
targeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to CHANGELOG.md
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

confirmed the correct type prefix in the PR title
confirmed all author checklist items have been addressed
reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

coderabbitai · 2024-06-24T16:35:44Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Base branches to auto review (1)

main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

alpe

Good progress. Nice set of new tests.

math/dec.go

alpe · 2024-06-25T13:11:26Z

math/dec_test.go

+			x:      NewDecWithPrec(1, 100_000),
+			y:      NewDecWithPrec(1, -1),
+			expErr: ErrInvalidDec,
+		},


I don't fully understand what QuoInteger is doing and how to use it. Should we remove it from the initial version until somebody has requirements?

math/dec_test.go

alpe · 2024-06-25T13:20:08Z

math/dec_test.go

+			y:   NewDecWithPrec(1234, -3),
+			exp: -1,
+		},
+	}


math/dec_test.go

alpe

Thanks for the updates! 👍

final bits

0000698

samricotta assigned alpe Jun 24, 2024

samricotta requested a review from a team as a code owner June 24, 2024 16:35

alpe reviewed Jun 25, 2024

View reviewed changes

comments

4a38cde

alpe approved these changes Jul 2, 2024

View reviewed changes

samricotta merged commit 090f3cc into sam/dec-type Jul 3, 2024
45 of 62 checks passed

samricotta deleted the sam/quo branch July 3, 2024 09:38

samricotta added a commit that referenced this pull request Jul 19, 2024

feat(math): Upstream GDA based decimal type testing (#20763)

cc09fe8

alpe pushed a commit that referenced this pull request Sep 30, 2024

feat(math): Upstream GDA based decimal type testing (#20763)

e5cd8cf

alpe pushed a commit that referenced this pull request Oct 27, 2024

feat(math): Upstream GDA based decimal type testing (#20763)

a863f2f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(math): Upstream GDA based decimal type testing #20763

feat(math): Upstream GDA based decimal type testing #20763

samricotta commented Jun 24, 2024 •

edited

Loading

coderabbitai bot commented Jun 24, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

alpe left a comment

alpe Jun 25, 2024

alpe Jun 25, 2024

alpe left a comment

feat(math): Upstream GDA based decimal type testing #20763

feat(math): Upstream GDA based decimal type testing #20763

Conversation

samricotta commented Jun 24, 2024 • edited Loading

Description

Author Checklist

Reviewers Checklist

coderabbitai bot commented Jun 24, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

alpe left a comment

Choose a reason for hiding this comment

alpe Jun 25, 2024

Choose a reason for hiding this comment

alpe Jun 25, 2024

Choose a reason for hiding this comment

alpe left a comment

Choose a reason for hiding this comment

samricotta commented Jun 24, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)