R4R: Fix broken invariant of bonded validator power decrease #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
commented
Aug 17, 2018
| validator = k.bondValidator(ctx, validatorToBond) | ||
| if bytes.Equal(validator.Owner, affectedValidator.Owner) { | ||
| return validator, true | ||
| } | ||
|
|
||
| return affectedValidator, true |
There was a problem hiding this comment.
Not sure if this is ideal, but in case line # 472 get executed, I need to make sure UpdateValidator set's the newly modified affectedValidator which should have it's status set to unbonded.
alexanderbez
commented
Aug 17, 2018
x/stake/keeper/validator.go
Outdated
| if !found { | ||
| panic(fmt.Sprintf("validator record not found for address: %v\n", oldCliffValidatorAddr)) | ||
| } | ||
|
|
||
| k.unbondValidator(ctx, cliffVal) | ||
| affectedValRank := GetValidatorsByPowerIndexKey(affectedValidator, pool) |
There was a problem hiding this comment.
@cwgoes lmk if this is analogous to what you had in your initial fix?
alexanderbez
changed the title
cwgoes
suggested changes
Aug 17, 2018
PENDING.md
Outdated
| @@ -47,6 +47,7 @@ BUG FIXES | |||
| * Gaia CLI (`gaiacli`) | |||
|
|
|||
| * Gaia | |||
| * [x/stake] [#2083] Fix broken invariant of bonded validator power decrease | |||
There was a problem hiding this comment.
Put this in CHANGELOG.md since we're merging into the release
| validator = k.bondValidator(ctx, validatorToBond) | ||
| if bytes.Equal(validator.Owner, affectedValidator.Owner) { | ||
| return validator, true | ||
| } | ||
|
|
||
| return affectedValidator, true |
Codecov Report
@@ Coverage Diff @@
## release/v0.24.0 #2083 +/- ##
===================================================
+ Coverage 63.73% 63.75% +0.02%
===================================================
Files 113 113
Lines 6667 6671 +4
===================================================
+ Hits 4249 4253 +4
Misses 2133 2133
Partials 285 285 |
alexanderbez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2071
docs/)PENDING.mdthat include links to the relevant issue or PR that most accurately describes the change.cmd/gaiaandexamples/For Admin Use: