R4R: Query staking Pool and Params #2099
Conversation
fedekunze
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2099 +/- ##
========================================
Coverage 63.82% 63.82%
========================================
Files 113 113
Lines 6684 6684
========================================
Hits 4266 4266
Misses 2135 2135
Partials 283 283 |
fedekunze
changed the title
client/lcd/lcd_test.go
Outdated
| @@ -353,6 +353,35 @@ func TestTxs(t *testing.T) { | |||
| require.Equal(t, resultTx.Height, indexedTxs[0].Height) | |||
| } | |||
|
|
|||
| func TestPoolQuery(t *testing.T) { | |||
| _, password := "test", "1234567890" | |||
There was a problem hiding this comment.
Can you make the first parameter a variable, and use it in the subsequent line.
client/lcd/lcd_test.go
Outdated
| } | ||
|
|
||
| func TestParamsQuery(t *testing.T) { | ||
| _, password := "test", "1234567890" |
There was a problem hiding this comment.
will merge both into one test
client/lcd/lcd_test.go
Outdated
| defer cleanup() | ||
|
|
||
| res, body := Request(t, port, "GET", "/stake/pool", nil) | ||
| require.Equal(t, http.StatusOK, res.StatusCode, body) |
There was a problem hiding this comment.
Let's do some check on the body? Currently this test just ensures that the endpoint doesn't error, not that it actually does anything.
There was a problem hiding this comment.
@ValarDragon I'm trying to compare the initial pool with the returned one
expected: types.Pool{
LooseTokens:1000000000000,
BondedTokens:0,
InflationLastTime:time.Time{wall:0x0, ext:62135596800, loc:(*time.Location)(0x22aad00)},
Inflation:700000000,
DateLastCommissionReset:0,
PrevBondedShares:0}
actual : types.Pool{
LooseTokens:1500019965200,
BondedTokens:1000000000000,
InflationLastTime:time.Time{wall:0x1d6c1165, ext:63670381882, loc:(*time.Location)(nil)},
Inflation:700059763,
DateLastCommissionReset:0,
PrevBondedShares:0}
There was a problem hiding this comment.
@ValarDragon could you help me figuring out where LooseTokens, BondedTokens and Inflation are updated once you initialize LCD?
|
Please rebase on develop. |
fedekunze
dismissed
ValarDragon’s stale review
addressed. Tests for Pool are working now
Closes #2011, #2012
API docs for LCD endpoints are being updated in #2066
docs/)PENDING.mdthat include links to the relevant issue or PR that most accurately describes the change.cmd/gaiaandexamples/For Admin Use: