Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple integration tests for {base,demo}coind #2124

Merged
merged 3 commits into from
Aug 23, 2018

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Aug 22, 2018

Test basecoind init && basecoind start sequence for both basecoin and democoin.

Closes: #1632

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 22, 2018

Codecov Report

Merging #2124 into develop will increase coverage by 1.59%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2124      +/-   ##
===========================================
+ Coverage     62.2%   63.79%   +1.59%     
===========================================
  Files          115      134      +19     
  Lines         6874     8157    +1283     
===========================================
+ Hits          4276     5204     +928     
- Misses        2314     2604     +290     
- Partials       284      349      +65

Move `make test_examples` into integraton_tests.
@alessio alessio force-pushed the alessio/1632-examples-simple-integration-tests branch from 2172a59 to ceb33ca Compare August 23, 2018 07:55
@fedekunze
Copy link
Collaborator

@alessio you forgot to update PENDING.md

@alessio
Copy link
Contributor Author

alessio commented Aug 23, 2018

@fedekunze done, thanks for pointing it out!

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit f8f97f7 into develop Aug 23, 2018
@cwgoes cwgoes deleted the alessio/1632-examples-simple-integration-tests branch August 23, 2018 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants